Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 502233002: Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages (Closed)

Created:
6 years, 4 months ago by Jeffrey Yasskin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/f032b471042c2a93d504c5fdeb8a685dd06e8962 Cr-Commit-Position: refs/heads/master@{#291809}

Patch Set 1 #

Patch Set 2 : There were extra failures with slightly different traces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 4 months ago (2014-08-25 23:25:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/502233002/20001
6 years, 4 months ago (2014-08-25 23:28:41 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 00:07:57 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 00:07:59 UTC) #4
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 4 months ago (2014-08-26 00:26:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/502233002/20001
6 years, 4 months ago (2014-08-26 00:30:14 UTC) #6
Jeffrey Yasskin
Committed patchset #2 to pending queue manually as 8da39ba (presubmit successful).
6 years, 4 months ago (2014-08-26 00:31:32 UTC) #7
haraken
LGTM
6 years, 4 months ago (2014-08-26 00:55:20 UTC) #8
Mads Ager (chromium)
LGTM After the git migration it looks a little hard to figure out when the ...
6 years, 4 months ago (2014-08-26 06:11:59 UTC) #9
Jeffrey Yasskin
A revert of this CL (patchset #2) has been created in https://codereview.chromium.org/507833002/ by jyasskin@chromium.org. The ...
6 years, 3 months ago (2014-08-26 21:12:00 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f032b471042c2a93d504c5fdeb8a685dd06e8962
Cr-Commit-Position: refs/heads/master@{#291809}

Powered by Google App Engine
This is Rietveld 408576698