Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4079)

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 50223002: Prevent modal dialogs when preparing to swap out. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase after RVHM moved Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index a3401c34afbd282b8a45ed5bebb53c90d0ca7d19..45070076c5417d58cdca2a8d3dba68612d12c115 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -290,6 +290,12 @@ class CONTENT_EXPORT RenderViewHostImpl
// different process.
bool is_swapped_out() const { return is_swapped_out_; }
+ // Tells the renderer that this RenderView will soon be swapped out, and thus
+ // not to create any new modal dialogs until it happens. This must be done
+ // separately so that the PageGroupLoadDeferrers of any current dialogs are no
+ // longer on the stack when we attempt to swap it out.
+ void SuppressDialogsUntilSwapOut();
+
// Tells the renderer that this RenderView is being swapped out for one in a
// different renderer process. It should run its unload handler and move to
// a blank document. The renderer should preserve the Frame object until it

Powered by Google App Engine
This is Rietveld 408576698