Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: content/renderer/render_view_impl.h

Issue 50223002: Prevent modal dialogs when preparing to swap out. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 6cf59f3b3862f406ce9c2435ddb3edadd1911c43..8f3b7ee30bf47fa2c72672ec75104a69f579864b 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -1005,6 +1005,7 @@ class CONTENT_EXPORT RenderViewImpl
void OnShouldClose();
void OnStop();
void OnStopFinding(StopFindAction action);
+ void OnSuppressDialogsUntilSwapOut();
void OnSwapOut();
void OnThemeChanged();
void OnUpdateTargetURLAck();
@@ -1245,6 +1246,11 @@ class CONTENT_EXPORT RenderViewImpl
// decidePolicyForNavigation for details.
bool opener_suppressed_;
+ // Whether we must stop creating nested message loops for modal dialogs until
+ // OnSwapOut is called. This is necessary because modal dialogs have a
+ // PageGroupLoadDeferrer on the stack that interferes with swapping out.
+ bool suppress_dialogs_until_swap_out_;
+
// Holds state pertaining to a navigation that we initiated. This is held by
// the WebDataSource::ExtraData attribute. We use pending_navigation_state_
// as a temporary holder for the state until the WebDataSource corresponding

Powered by Google App Engine
This is Rietveld 408576698