Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 50223002: Prevent modal dialogs when preparing to swap out. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase after RVHM moved Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 988 matching lines...) Expand 10 before | Expand all | Expand 10 after
999 void OnSetHistoryLengthAndPrune(int history_length, int32 minimum_page_id); 999 void OnSetHistoryLengthAndPrune(int history_length, int32 minimum_page_id);
1000 void OnSetInitialFocus(bool reverse); 1000 void OnSetInitialFocus(bool reverse);
1001 void OnSetPageEncoding(const std::string& encoding_name); 1001 void OnSetPageEncoding(const std::string& encoding_name);
1002 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs); 1002 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs);
1003 void OnSetWebUIProperty(const std::string& name, const std::string& value); 1003 void OnSetWebUIProperty(const std::string& name, const std::string& value);
1004 void OnSetZoomLevel(double zoom_level); 1004 void OnSetZoomLevel(double zoom_level);
1005 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level); 1005 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level);
1006 void OnShouldClose(); 1006 void OnShouldClose();
1007 void OnStop(); 1007 void OnStop();
1008 void OnStopFinding(StopFindAction action); 1008 void OnStopFinding(StopFindAction action);
1009 void OnSuppressDialogsUntilSwapOut();
1009 void OnSwapOut(); 1010 void OnSwapOut();
1010 void OnThemeChanged(); 1011 void OnThemeChanged();
1011 void OnUpdateTargetURLAck(); 1012 void OnUpdateTargetURLAck();
1012 void OnUpdateTimezone(); 1013 void OnUpdateTimezone();
1013 void OnUpdateWebPreferences(const WebPreferences& prefs); 1014 void OnUpdateWebPreferences(const WebPreferences& prefs);
1014 void OnZoom(PageZoom zoom); 1015 void OnZoom(PageZoom zoom);
1015 void OnZoomFactor(PageZoom zoom, int zoom_center_x, int zoom_center_y); 1016 void OnZoomFactor(PageZoom zoom, int zoom_center_x, int zoom_center_y);
1016 void OnEnableViewSourceMode(); 1017 void OnEnableViewSourceMode();
1017 void OnDisownOpener(); 1018 void OnDisownOpener();
1018 void OnWindowSnapshotCompleted(const int snapshot_id, 1019 void OnWindowSnapshotCompleted(const int snapshot_id,
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
1231 NavigationGesture navigation_gesture_; 1232 NavigationGesture navigation_gesture_;
1232 1233
1233 // Used for popups. 1234 // Used for popups.
1234 bool opened_by_user_gesture_; 1235 bool opened_by_user_gesture_;
1235 1236
1236 // Whether this RenderView was created by a frame that was suppressing its 1237 // Whether this RenderView was created by a frame that was suppressing its
1237 // opener. If so, we may want to load pages in a separate process. See 1238 // opener. If so, we may want to load pages in a separate process. See
1238 // decidePolicyForNavigation for details. 1239 // decidePolicyForNavigation for details.
1239 bool opener_suppressed_; 1240 bool opener_suppressed_;
1240 1241
1242 // Whether we must stop creating nested message loops for modal dialogs until
1243 // OnSwapOut is called. This is necessary because modal dialogs have a
1244 // PageGroupLoadDeferrer on the stack that interferes with swapping out.
1245 bool suppress_dialogs_until_swap_out_;
1246
1241 // Holds state pertaining to a navigation that we initiated. This is held by 1247 // Holds state pertaining to a navigation that we initiated. This is held by
1242 // the WebDataSource::ExtraData attribute. We use pending_navigation_state_ 1248 // the WebDataSource::ExtraData attribute. We use pending_navigation_state_
1243 // as a temporary holder for the state until the WebDataSource corresponding 1249 // as a temporary holder for the state until the WebDataSource corresponding
1244 // to the new navigation is created. See DidCreateDataSource. 1250 // to the new navigation is created. See DidCreateDataSource.
1245 scoped_ptr<ViewMsg_Navigate_Params> pending_navigation_params_; 1251 scoped_ptr<ViewMsg_Navigate_Params> pending_navigation_params_;
1246 1252
1247 // Timer used to delay the updating of nav state (see SyncNavigationState). 1253 // Timer used to delay the updating of nav state (see SyncNavigationState).
1248 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_; 1254 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_;
1249 1255
1250 // Page IDs ------------------------------------------------------------------ 1256 // Page IDs ------------------------------------------------------------------
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
1551 // use the Observer interface to filter IPC messages and receive frame change 1557 // use the Observer interface to filter IPC messages and receive frame change
1552 // notifications. 1558 // notifications.
1553 // --------------------------------------------------------------------------- 1559 // ---------------------------------------------------------------------------
1554 1560
1555 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1561 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1556 }; 1562 };
1557 1563
1558 } // namespace content 1564 } // namespace content
1559 1565
1560 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1566 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698