Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 50223002: Prevent modal dialogs when preparing to swap out. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 990 matching lines...) Expand 10 before | Expand all | Expand 10 after
1001 void OnSetHistoryLengthAndPrune(int history_length, int32 minimum_page_id); 1001 void OnSetHistoryLengthAndPrune(int history_length, int32 minimum_page_id);
1002 void OnSetInitialFocus(bool reverse); 1002 void OnSetInitialFocus(bool reverse);
1003 void OnSetPageEncoding(const std::string& encoding_name); 1003 void OnSetPageEncoding(const std::string& encoding_name);
1004 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs); 1004 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs);
1005 void OnSetWebUIProperty(const std::string& name, const std::string& value); 1005 void OnSetWebUIProperty(const std::string& name, const std::string& value);
1006 void OnSetZoomLevel(double zoom_level); 1006 void OnSetZoomLevel(double zoom_level);
1007 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level); 1007 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level);
1008 void OnShouldClose(); 1008 void OnShouldClose();
1009 void OnStop(); 1009 void OnStop();
1010 void OnStopFinding(StopFindAction action); 1010 void OnStopFinding(StopFindAction action);
1011 void OnSuppressDialogsUntilSwapOut();
1011 void OnSwapOut(); 1012 void OnSwapOut();
1012 void OnThemeChanged(); 1013 void OnThemeChanged();
1013 void OnUpdateTargetURLAck(); 1014 void OnUpdateTargetURLAck();
1014 void OnUpdateTimezone(); 1015 void OnUpdateTimezone();
1015 void OnUpdateWebPreferences(const WebPreferences& prefs); 1016 void OnUpdateWebPreferences(const WebPreferences& prefs);
1016 void OnZoom(PageZoom zoom); 1017 void OnZoom(PageZoom zoom);
1017 void OnZoomFactor(PageZoom zoom, int zoom_center_x, int zoom_center_y); 1018 void OnZoomFactor(PageZoom zoom, int zoom_center_x, int zoom_center_y);
1018 void OnEnableViewSourceMode(); 1019 void OnEnableViewSourceMode();
1019 void OnDisownOpener(); 1020 void OnDisownOpener();
1020 void OnWindowSnapshotCompleted(const int snapshot_id, 1021 void OnWindowSnapshotCompleted(const int snapshot_id,
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
1243 NavigationGesture navigation_gesture_; 1244 NavigationGesture navigation_gesture_;
1244 1245
1245 // Used for popups. 1246 // Used for popups.
1246 bool opened_by_user_gesture_; 1247 bool opened_by_user_gesture_;
1247 1248
1248 // Whether this RenderView was created by a frame that was suppressing its 1249 // Whether this RenderView was created by a frame that was suppressing its
1249 // opener. If so, we may want to load pages in a separate process. See 1250 // opener. If so, we may want to load pages in a separate process. See
1250 // decidePolicyForNavigation for details. 1251 // decidePolicyForNavigation for details.
1251 bool opener_suppressed_; 1252 bool opener_suppressed_;
1252 1253
1254 // Whether we must stop creating nested message loops for modal dialogs until
1255 // OnSwapOut is called. This is necessary because modal dialogs have a
1256 // PageGroupLoadDeferrer on the stack that interferes with swapping out.
1257 bool suppress_dialogs_until_swap_out_;
1258
1253 // Holds state pertaining to a navigation that we initiated. This is held by 1259 // Holds state pertaining to a navigation that we initiated. This is held by
1254 // the WebDataSource::ExtraData attribute. We use pending_navigation_state_ 1260 // the WebDataSource::ExtraData attribute. We use pending_navigation_state_
1255 // as a temporary holder for the state until the WebDataSource corresponding 1261 // as a temporary holder for the state until the WebDataSource corresponding
1256 // to the new navigation is created. See DidCreateDataSource. 1262 // to the new navigation is created. See DidCreateDataSource.
1257 scoped_ptr<ViewMsg_Navigate_Params> pending_navigation_params_; 1263 scoped_ptr<ViewMsg_Navigate_Params> pending_navigation_params_;
1258 1264
1259 // Timer used to delay the updating of nav state (see SyncNavigationState). 1265 // Timer used to delay the updating of nav state (see SyncNavigationState).
1260 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_; 1266 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_;
1261 1267
1262 // Page IDs ------------------------------------------------------------------ 1268 // Page IDs ------------------------------------------------------------------
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
1560 // use the Observer interface to filter IPC messages and receive frame change 1566 // use the Observer interface to filter IPC messages and receive frame change
1561 // notifications. 1567 // notifications.
1562 // --------------------------------------------------------------------------- 1568 // ---------------------------------------------------------------------------
1563 1569
1564 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1570 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1565 }; 1571 };
1566 1572
1567 } // namespace content 1573 } // namespace content
1568 1574
1569 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1575 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698