Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: dm/DMWriteTask.cpp

Issue 502193002: SkData to SkStreamAsset to avoid unneeded copying (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dm/DMPDFTask.cpp ('K') | « dm/DMWriteTask.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMWriteTask.cpp
diff --git a/dm/DMWriteTask.cpp b/dm/DMWriteTask.cpp
index b8ce3189a843ee6ce0be45d04d4b2ee37b917de8..149071276cf581cddcb11215655725b2fb1da37b 100644
--- a/dm/DMWriteTask.cpp
+++ b/dm/DMWriteTask.cpp
@@ -41,10 +41,10 @@ WriteTask::WriteTask(const Task& parent, SkBitmap bitmap)
, fData(NULL)
, fExtension(".png") {}
-WriteTask::WriteTask(const Task& parent, SkData *data, const char* ext)
+WriteTask::WriteTask(const Task& parent, SkStreamAsset *data, const char* ext)
: CpuTask(parent)
, fGmName(find_gm_name(parent, &fSuffixes))
- , fData(SkRef(data))
+ , fData(data)
, fExtension(ext) {}
void WriteTask::makeDirOrFail(SkString dir) {
@@ -115,9 +115,10 @@ struct PngAndRaw {
};
// Does not take ownership of data.
-bool save_data_to_file(const SkData* data, const char* path) {
+bool save_data_to_file(SkStreamAsset* data, const char* path) {
+ data->rewind();
SkFILEWStream stream(path);
- if (!stream.isValid() || !stream.write(data->data(), data->size())) {
+ if (!stream.isValid() || !stream.writeStream(data, data->getLength())) {
SkDebugf("Can't write %s.\n", path);
return false;
}
« dm/DMPDFTask.cpp ('K') | « dm/DMWriteTask.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698