Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Unified Diff: dm/DMPDFRasterizeTask.h

Issue 502193002: SkData to SkStreamAsset to avoid unneeded copying (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dm/DMPDFRasterizeTask.cpp » ('j') | dm/DMPDFTask.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMPDFRasterizeTask.h
diff --git a/dm/DMPDFRasterizeTask.h b/dm/DMPDFRasterizeTask.h
index 2cc1ef70dabdbe4a877544b7ac31df4f0e1c512c..d5d983c936300535b95b68d0631eb70409cf1aca 100644
--- a/dm/DMPDFRasterizeTask.h
+++ b/dm/DMPDFRasterizeTask.h
@@ -21,8 +21,9 @@ typedef bool (*RasterizePdfProc)(SkStream* pdf, SkBitmap* output);
class PDFRasterizeTask : public CpuTask {
public:
+ // takes ownership of SkStreamAsset.
mtklein 2014/08/25 21:44:33 I'm finding this hard to think about. Can we not
hal.canary 2014/08/26 15:20:50 SkStreams should not be reference counted, since i
mtklein 2014/08/26 15:30:54 Gotcha. Let's make it SkAutoTDelete then. Your e
PDFRasterizeTask(const Task& parent,
- SkData* pdf,
+ SkStreamAsset* pdf,
RasterizePdfProc);
virtual void draw() SK_OVERRIDE;
@@ -31,7 +32,7 @@ public:
private:
const SkString fName;
- SkAutoTUnref<SkData> fPdf;
+ SkAutoTUnref<SkStreamAsset> fPdf;
RasterizePdfProc fRasterize;
};
« no previous file with comments | « no previous file | dm/DMPDFRasterizeTask.cpp » ('j') | dm/DMPDFTask.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698