chrome/browser/local_discovery/privet_notifications_unittest.cc - Issue 502173004: Remove implicit conversions from scoped_refptr to T* in chrome/browser/local_discovery/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/privet_notifications_unittest.cc

Issue 502173004: Remove implicit conversions from scoped_refptr to T* in chrome/browser/local_discovery/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/privet_notifications.cc ('k') | chrome/browser/local_discovery/privet_traffic_detector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/privet_notifications_unittest.cc

diff --git a/chrome/browser/local_discovery/privet_notifications_unittest.cc b/chrome/browser/local_discovery/privet_notifications_unittest.cc

index a219dae0fd415f991ef1e6f027837dacf43f9d74..2cdcf71ca0ac254d0000bcfe5be7b15c7ad5b97c 100644

--- a/chrome/browser/local_discovery/privet_notifications_unittest.cc

+++ b/chrome/browser/local_discovery/privet_notifications_unittest.cc

@@ -52,11 +52,8 @@ class MockPrivetHttpFactory : public PrivetHTTPAsynchronousFactory {

}

virtual void Start() OVERRIDE {

- callback_.Run(scoped_ptr<PrivetHTTPClient>(

- new PrivetHTTPClientImpl(

- name_,

- net::HostPortPair("1.2.3.4", 8080),

- request_context_)));

+ callback_.Run(scoped_ptr<PrivetHTTPClient>(new PrivetHTTPClientImpl(

+ name_, net::HostPortPair("1.2.3.4", 8080), request_context_.get())));

}

virtual const std::string& GetName() OVERRIDE {

@@ -78,7 +75,7 @@ class MockPrivetHttpFactory : public PrivetHTTPAsynchronousFactory {

const net::HostPortPair& address,

const ResultCallback& callback) OVERRIDE {

return scoped_ptr<PrivetHTTPResolution>(

- new MockResolution(name, request_context_, callback));

+ new MockResolution(name, request_context_.get(), callback));

}

private: