Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 50213003: Do deferred migration of maps after deoptimizing once. (Closed)

Created:
7 years, 1 month ago by Hannes Payer (out of office)
Modified:
7 years, 1 month ago
Reviewers:
danno, Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Do deferred migration of maps after deoptimizing once. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17949

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Hannes Payer (out of office)
7 years, 1 month ago (2013-10-29 08:35:52 UTC) #1
danno
Getting there, but I think you need to make sure that bit_field4 is set to ...
7 years, 1 month ago (2013-11-04 17:37:29 UTC) #2
Toon Verwaest
https://codereview.chromium.org/50213003/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/50213003/diff/1/src/objects-inl.h#newcode4294 src/objects-inl.h:4294: // necessary to be able to use the 31st ...
7 years, 1 month ago (2013-11-04 17:52:46 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/50213003/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/50213003/diff/1/src/objects-inl.h#newcode4294 src/objects-inl.h:4294: // necessary to be able to use the 31st ...
7 years, 1 month ago (2013-11-20 10:36:47 UTC) #4
Toon Verwaest
https://codereview.chromium.org/50213003/diff/70001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/50213003/diff/70001/src/hydrogen-instructions.h#newcode2828 src/hydrogen-instructions.h:2828: map->has_migrated()) { The map cannot both be a migration ...
7 years, 1 month ago (2013-11-20 10:45:54 UTC) #5
Toon Verwaest
lgtm
7 years, 1 month ago (2013-11-20 14:30:54 UTC) #6
Hannes Payer (out of office)
7 years, 1 month ago (2013-11-21 09:16:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r17949.

Powered by Google App Engine
This is Rietveld 408576698