Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 502103003: Prevent the screen from sleeping when the desktop is being captured. (Closed)

Created:
6 years, 4 months ago by jiayl
Modified:
6 years, 3 months ago
Reviewers:
Sergey Ulanov, juberti2
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prevent the screen from sleeping when the desktop is being captured. BUG=405784 Committed: https://crrev.com/aea4a57a952865dca22498a92c1abafa13d6507a Cr-Commit-Position: refs/heads/master@{#291908}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M content/browser/media/capture/desktop_capture_device.cc View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 2 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
jiayl
jiayl@chromium.org changed reviewers: + sergeyu@chromium.org
6 years, 4 months ago (2014-08-25 19:13:27 UTC) #1
jiayl
Sergey, PTAL.
6 years, 4 months ago (2014-08-25 19:13:27 UTC) #2
juberti2
juberti@chromium.org changed reviewers: + juberti@chromium.org
6 years, 4 months ago (2014-08-25 19:16:24 UTC) #3
juberti2
https://codereview.chromium.org/502103003/diff/1/content/browser/media/capture/desktop_capture_device.cc File content/browser/media/capture/desktop_capture_device.cc (right): https://codereview.chromium.org/502103003/diff/1/content/browser/media/capture/desktop_capture_device.cc#newcode172 content/browser/media/capture/desktop_capture_device.cc:172: "DesktopCatureDevice is running").release()); DesktopCatureDevice -> DesktopCaptureDevice (here and other ...
6 years, 4 months ago (2014-08-25 19:16:24 UTC) #4
jiayl
https://codereview.chromium.org/502103003/diff/1/content/browser/media/capture/desktop_capture_device.cc File content/browser/media/capture/desktop_capture_device.cc (right): https://codereview.chromium.org/502103003/diff/1/content/browser/media/capture/desktop_capture_device.cc#newcode172 content/browser/media/capture/desktop_capture_device.cc:172: "DesktopCatureDevice is running").release()); On 2014/08/25 19:16:24, juberti2 wrote: > ...
6 years, 4 months ago (2014-08-25 19:50:01 UTC) #5
Sergey Ulanov
I'd prefer treating this as a temporary solution until we have a proper solution using ...
6 years, 3 months ago (2014-08-25 23:45:10 UTC) #6
juberti2
On 2014/08/25 23:45:10, Sergey Ulanov wrote: > I'd prefer treating this as a temporary solution ...
6 years, 3 months ago (2014-08-25 23:46:39 UTC) #7
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 3 months ago (2014-08-25 23:51:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/502103003/40001
6 years, 3 months ago (2014-08-25 23:53:14 UTC) #9
Sergey Ulanov
On 2014/08/25 23:46:39, juberti2 wrote: > On 2014/08/25 23:45:10, Sergey Ulanov wrote: > > I'd ...
6 years, 3 months ago (2014-08-25 23:55:31 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 02:43:42 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 02:43:44 UTC) #12
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 3 months ago (2014-08-26 15:31:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/502103003/40001
6 years, 3 months ago (2014-08-26 15:31:50 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (40001) as 617f203d9ff1d06b45e45613533b2aacbfe1a76c
6 years, 3 months ago (2014-08-26 15:34:14 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:59 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aea4a57a952865dca22498a92c1abafa13d6507a
Cr-Commit-Position: refs/heads/master@{#291908}

Powered by Google App Engine
This is Rietveld 408576698