Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 502083003: Rolled src/tools/grit r172:173. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
szager1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rolled src/tools/grit r172:173. Rolled src/tools/grit from revision 6a46b04d35eade32b1270392317dca516c9dd56d to revision 206c6aa4450db4e961d20f8367f33df42bba6a85 Summary of changes available at: https://chromium.googlesource.com/external/grit-i18n/+log/6a46b04d35ea..206c6aa4450d BUG=333201 Committed: https://crrev.com/05fc40e1d681a46dc7659d7a929f4215f41909c1 Cr-Commit-Position: refs/heads/master@{#292007}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + szager@chromium.org
6 years, 4 months ago (2014-08-26 02:49:12 UTC) #1
Lei Zhang
Let's try this again now that the dust has settled.
6 years, 4 months ago (2014-08-26 02:49:12 UTC) #2
szager1
lgtm
6 years, 3 months ago (2014-08-26 10:57:11 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-26 20:27:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/502083003/1
6 years, 3 months ago (2014-08-26 20:29:06 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 20:43:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 20:45:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/49447) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6768) win8_chromium_rel ...
6 years, 3 months ago (2014-08-26 20:45:36 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-26 20:54:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/502083003/20001
6 years, 3 months ago (2014-08-26 20:57:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (20001) as a8f5b2ab7c415567da0be9c6ceb99b28a25e0e3b
6 years, 3 months ago (2014-08-26 22:35:23 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:46:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05fc40e1d681a46dc7659d7a929f4215f41909c1
Cr-Commit-Position: refs/heads/master@{#292007}

Powered by Google App Engine
This is Rietveld 408576698