Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: pkg/template_binding/lib/src/input_bindings.dart

Issue 50203004: port TemplateBinding to ed3266266e751b5ab1f75f8e0509d0d5f0ef35d8 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/template_binding/lib/src/element.dart ('k') | pkg/template_binding/lib/src/instance_binding_map.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/template_binding/lib/src/input_bindings.dart
diff --git a/pkg/template_binding/lib/src/input_bindings.dart b/pkg/template_binding/lib/src/input_bindings.dart
index fc89dc5d1ae1d32e6e188afd6128a4fbd2e9505d..8e5b3b0c806be6557cc30b706673464dad33e1a4 100644
--- a/pkg/template_binding/lib/src/input_bindings.dart
+++ b/pkg/template_binding/lib/src/input_bindings.dart
@@ -148,11 +148,12 @@ class _SelectBinding extends _InputBinding {
// Instead we use scheduleMicrotask. Each <template repeat> needs a delay of
// 2:
// * once to happen after the child _TemplateIterator is created
- // * once to be after _TemplateIterator.inputs CompoundBinding resolve
+ // * once to be after _TemplateIterator's CompoundPathObserver resolve
// And then we need to do this delay sequence twice:
// * once for OPTGROUP
// * once for OPTION.
// The resulting 2 * 2 is our maxRetries.
+ //
// TODO(jmesserly): a much better approach would be to find the nested
// <template> and wait on some future that completes when it has expanded.
var maxRetries = 4;
« no previous file with comments | « pkg/template_binding/lib/src/element.dart ('k') | pkg/template_binding/lib/src/instance_binding_map.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698