port TemplateBinding to ed3266266e751b5ab1f75f8e0509d0d5f0ef35d8

pkg/polymer/test/event_handlers_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library polymer.test.event_handlers_test;
 
 import 'dart:async';
 import 'dart:html';
 
+import 'package:logging/logging.dart';
+import 'package:polymer/polymer.dart';
+import 'package:template_binding/template_binding.dart';
 import 'package:unittest/unittest.dart';
 import 'package:unittest/html_config.dart';
-import 'package:polymer/polymer.dart';
-import 'package:template_binding/template_binding.dart';
 
 @CustomTag('x-test')
 class XTest extends PolymerElement {
   int _testCount = 0;
   String _lastEvent;
   String _lastMessage;
   List list1 = [];
   List list2 = [];
-  final _ready = new Completer();
-  Future _onTestDone;
+  final _onTestDone = new Completer();
 
-  XTest.created() : super.created() {
-    _onTestDone = _ready.future.then(_runTest);
-  }
+  XTest.created() : super.created();
 
   ready() {
     super.ready();
     for (var i = 0; i < 10; i++) {
       var model = new MiniModel(this, i);
       list1.add(model);
       list2.add(model);
     }
-    _ready.complete();
+
+    // TODO(jmesserly): is there a cleaner way to do this?
+    new Future.sync(_runTests).then((x) { _onTestDone.complete(x); },
+        onError: (e, s) { _onTestDone.completeError(e, s); });

[Siggi Cherem (dart-lang), 2013/10/29 22:49:49]

I'm still surprised by this. Especially that you need the onError here.

I was expecting something like:

  _onTestDone = new Future.sync(_runTests);

(after changing _onTestDone back to be a future)
I thought future.sync 

[Jennifer Messerly, 2013/10/29 23:07:19]

you're right. ready will be called sync from created. Fixed!

   }
 
   hostTapAction(event, detail, node) => _logEvent(event);
 
   divTapAction(event, detail, node) => _logEvent(event);
 
   focusAction(event, detail, node) => _logEvent(event);
 
   blurAction(event, detail, node) => _logEvent(event);
 
   scrollAction(event, detail, node) => _logEvent(event);
 
   itemTapAction(event, detail, node) {
     var model = nodeBind(event.target).templateInstance.model;
     _logEvent(event, "x-test callback ${model['this']}");
   }
 
   _logEvent(event, [message]) {
     _testCount++;
     _lastEvent = event.type;
     _lastMessage = message;
   }
 
-  _runTest(_) {
+  Future _runTests() {
     fire('tap', toNode: $['div']);
     expect(_testCount, 2, reason: 'event heard at div and host');
     expect(_lastEvent, 'tap', reason: 'tap handled');
     fire('focus', toNode: $['input'], canBubble: false);
     expect(_testCount, 3, reason: 'event heard by input');
     expect(_lastEvent, 'focus', reason: 'focus handled');
     fire('blur', toNode: $['input'], canBubble: false);
     expect(_testCount, 4, reason: 'event heard by input');
     expect(_lastEvent, 'blur', reason: 'blur handled');
     fire('scroll', toNode: $['list'], canBubble: false);
     expect(_testCount, 5, reason: 'event heard by list');
     expect(_lastEvent, 'scroll', reason: 'scroll handled');
+
     return onMutation($['list']).then((_) {
       var l1 = $['list'].querySelectorAll('.list1')[4];
       fire('tap', toNode: l1, canBubble: false);
       expect(_testCount, 6, reason: 'event heard by list1 item');
       expect(_lastEvent, 'tap', reason: 'tap handled');
       expect(_lastMessage, 'x-test callback <mini-model 4>');
 
       var l2 = $['list'].querySelectorAll('.list2')[3];
       fire('tap', toNode: l2, canBubble: false);
       expect(_testCount, 7, reason: 'event heard by list2 item');
@@ skipping 13 matching lines @@
   }
   MiniModel(this._element, this.index) {
     // TODO(sigmund): remove this and reflect directly on the method. This is
     // needed to work around bug 13002
     itemTapAction = _itemTapAction;
   }
   String toString() => "<mini-model $index>";
 }
 
 main() {
+  Logger.root..level = Level.FINE
+      ..onRecord.listen((m) => print('${m.loggerName} ${m.message}'));
+
   initPolymer();
 }
 
 @initMethod _init() {
   useHtmlConfiguration();
 
   setUp(() => Polymer.onReady);
   test('events handled', () => (query('x-test') as XTest)._onTestDone);

[Siggi Cherem (dart-lang), 2013/10/29 22:49:49]

should this return _onTestDone.future?

[Jennifer Messerly, 2013/10/29 23:07:19]

fixed. it's now a future. added an expect so we know for sure it's non null :)

 }