Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: base/power_monitor/power_monitor.cc

Issue 502003003: Check to ensure PowerObservers are added and removed on the same thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated BUILD.gn Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/base.gypi ('k') | base/power_monitor/power_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/power_monitor/power_monitor.h" 5 #include "base/power_monitor/power_monitor.h"
6 #include "base/logging.h"
6 #include "base/power_monitor/power_monitor_source.h" 7 #include "base/power_monitor/power_monitor_source.h"
7 8
8 namespace base { 9 namespace base {
9 10
10 static PowerMonitor* g_power_monitor = NULL; 11 static PowerMonitor* g_power_monitor = NULL;
11 12
12 PowerMonitor::PowerMonitor(scoped_ptr<PowerMonitorSource> source) 13 PowerMonitor::PowerMonitor(scoped_ptr<PowerMonitorSource> source)
13 : observers_(new ObserverListThreadSafe<PowerObserver>()), 14 : observers_(new ObserverListThreadSafe<PowerObserver>()),
14 source_(source.Pass()) { 15 source_(source.Pass()) {
15 DCHECK(!g_power_monitor); 16 DCHECK(!g_power_monitor);
16 g_power_monitor = this; 17 g_power_monitor = this;
17 } 18 }
18 19
19 PowerMonitor::~PowerMonitor() { 20 PowerMonitor::~PowerMonitor() {
20 DCHECK_EQ(this, g_power_monitor); 21 DCHECK_EQ(this, g_power_monitor);
21 g_power_monitor = NULL; 22 g_power_monitor = NULL;
22 } 23 }
23 24
24 // static 25 // static
25 PowerMonitor* PowerMonitor::Get() { 26 PowerMonitor* PowerMonitor::Get() {
26 return g_power_monitor; 27 return g_power_monitor;
27 } 28 }
28 29
29 void PowerMonitor::AddObserver(PowerObserver* obs) { 30 void PowerMonitor::AddObserver(PowerObserver* obs) {
31 DCHECK(!obs->power_monitor_thread_checker_);
32 obs->power_monitor_thread_checker_.reset(new base::ThreadChecker());
30 observers_->AddObserver(obs); 33 observers_->AddObserver(obs);
31 } 34 }
32 35
33 void PowerMonitor::RemoveObserver(PowerObserver* obs) { 36 void PowerMonitor::RemoveObserver(PowerObserver* obs) {
37 // PowerObservers must be removed on the same thread on which they were added.
38 DCHECK(obs->power_monitor_thread_checker_);
39 DCHECK(obs->power_monitor_thread_checker_->CalledOnValidThread());
34 observers_->RemoveObserver(obs); 40 observers_->RemoveObserver(obs);
41 obs->power_monitor_thread_checker_.reset();
35 } 42 }
36 43
37 PowerMonitorSource* PowerMonitor::Source() { 44 PowerMonitorSource* PowerMonitor::Source() {
38 return source_.get(); 45 return source_.get();
39 } 46 }
40 47
41 bool PowerMonitor::IsOnBatteryPower() { 48 bool PowerMonitor::IsOnBatteryPower() {
42 return source_->IsOnBatteryPower(); 49 return source_->IsOnBatteryPower();
43 } 50 }
44 51
45 void PowerMonitor::NotifyPowerStateChange(bool battery_in_use) { 52 void PowerMonitor::NotifyPowerStateChange(bool battery_in_use) {
46 DVLOG(1) << "PowerStateChange: " << (battery_in_use ? "On" : "Off") 53 DVLOG(1) << "PowerStateChange: " << (battery_in_use ? "On" : "Off")
47 << " battery"; 54 << " battery";
48 observers_->Notify(&PowerObserver::OnPowerStateChange, battery_in_use); 55 observers_->Notify(&PowerObserver::OnPowerStateChange, battery_in_use);
49 } 56 }
50 57
51 void PowerMonitor::NotifySuspend() { 58 void PowerMonitor::NotifySuspend() {
52 DVLOG(1) << "Power Suspending"; 59 DVLOG(1) << "Power Suspending";
53 observers_->Notify(&PowerObserver::OnSuspend); 60 observers_->Notify(&PowerObserver::OnSuspend);
54 } 61 }
55 62
56 void PowerMonitor::NotifyResume() { 63 void PowerMonitor::NotifyResume() {
57 DVLOG(1) << "Power Resuming"; 64 DVLOG(1) << "Power Resuming";
58 observers_->Notify(&PowerObserver::OnResume); 65 observers_->Notify(&PowerObserver::OnResume);
59 } 66 }
60 67
61 } // namespace base 68 } // namespace base
OLDNEW
« no previous file with comments | « base/base.gypi ('k') | base/power_monitor/power_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698