Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 501963002: List of users admitted for multi-profile should include user with NOT_ALLOWED_PRIMARY_POLICY_CERT_T… (Closed)

Created:
6 years, 4 months ago by Dmitry Polukhin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

List of users admitted for multi-profile should include user with NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED Value NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED was not check in the list of know problem when user cannot be added to the session. To avoid this types of errors removed list complete because the only vale that checked separate NOT_ALLOWED_PRIMARY_USER_POLICY_FORBIDS. BUG=406278 TEST=manual Committed: https://crrev.com/32892ca2391813d23e5738c7cabdce209ffdcc0b Cr-Commit-Position: refs/heads/master@{#291892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dmitry Polukhin
PTAL
6 years, 4 months ago (2014-08-25 15:57:47 UTC) #1
Dmitry Polukhin
dpolukhin@chromium.org changed reviewers: + ygorshenin@chromium.org
6 years, 4 months ago (2014-08-26 10:32:25 UTC) #2
Dmitry Polukhin
6 years, 4 months ago (2014-08-26 10:32:25 UTC) #3
ygorshenin1
lgtm
6 years, 4 months ago (2014-08-26 10:36:39 UTC) #4
Dmitry Polukhin
The CQ bit was checked by dpolukhin@chromium.org
6 years, 4 months ago (2014-08-26 10:38:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/501963002/1
6 years, 4 months ago (2014-08-26 10:39:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as bc8ed5ca40ad9f8fa4e8cd2401d11e60c9e55203
6 years, 3 months ago (2014-08-26 12:27:23 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32892ca2391813d23e5738c7cabdce209ffdcc0b
Cr-Commit-Position: refs/heads/master@{#291892}

Powered by Google App Engine
This is Rietveld 408576698