Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 501913002: cc: Enable renderer compositor impl-side painting on Mac. (Closed)

Created:
6 years, 4 months ago by ccameron
Modified:
6 years, 3 months ago
Reviewers:
danakj, reveman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Enable renderer compositor impl-side painting on Mac. TBR=piman@chromium.org BUG=169282 Committed: https://crrev.com/3ea412698878b6749b8c7a233824a6f31c6e837d Cr-Commit-Position: refs/heads/master@{#291721}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
ccameron
Anything I should worry about before going for it?
6 years, 4 months ago (2014-08-25 06:24:20 UTC) #1
reveman
On 2014/08/25 06:24:20, ccameron1 wrote: > Anything I should worry about before going for it? ...
6 years, 4 months ago (2014-08-25 07:16:56 UTC) #2
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 4 months ago (2014-08-25 17:30:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/501913002/1
6 years, 4 months ago (2014-08-25 17:30:36 UTC) #4
piman
https://codereview.chromium.org/501913002/diff/1/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/501913002/diff/1/content/browser/gpu/compositor_util.cc#newcode198 content/browser/gpu/compositor_util.cc:198: return true; nit: Some of those ifs can go ...
6 years, 4 months ago (2014-08-25 18:09:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as ffcc2137e4f952470000ce6330be0160360528e3
6 years, 4 months ago (2014-08-25 18:27:44 UTC) #6
reveman
https://codereview.chromium.org/501913002/diff/1/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/501913002/diff/1/content/browser/gpu/compositor_util.cc#newcode198 content/browser/gpu/compositor_util.cc:198: return true; On 2014/08/25 18:09:38, piman (OOO) wrote: > ...
6 years, 4 months ago (2014-08-25 21:18:54 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:57 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3ea412698878b6749b8c7a233824a6f31c6e837d
Cr-Commit-Position: refs/heads/master@{#291721}

Powered by Google App Engine
This is Rietveld 408576698