Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 501853003: Re-enable test fast/multicol/cell-shrinkback.html and make it pass. (Closed)

Created:
6 years, 3 months ago by mstensho (USE GERRIT)
Modified:
6 years, 3 months ago
Reviewers:
Peter Kasting
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Re-enable test fast/multicol/cell-shrinkback.html and make it pass. Preferred min/max widths are rounded up for table cells, but not for other types of shrink-to-fit containers, so using a table cell in the test and an abspos in the ref doesn't necessarily result in identical rendering. Specify a fixed width on the containers instead, so that the test isn't affected by this problem. The problem has nothing to do with multicol. BUG=397257 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/cell-shrinkback.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/cell-shrinkback-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mstensho (USE GERRIT)
6 years, 3 months ago (2014-08-27 12:40:24 UTC) #1
Peter Kasting
RS LGTM; if you want a real review by someone who understands the issues you'll ...
6 years, 3 months ago (2014-08-27 19:45:04 UTC) #2
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 3 months ago (2014-08-27 20:04:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/501853003/1
6 years, 3 months ago (2014-08-27 20:05:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 3 months ago (2014-08-27 21:04:39 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 21:30:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 180999

Powered by Google App Engine
This is Rietveld 408576698