Perform better input checks in early steps of parser.

Perform better input checks in early steps of parser.

BUG=406591
R=jun_fang@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/a3c7215

[Tom Sepez, 2014-08-25 19:26:10]

tsepez@chromium.org changed reviewers:
+ jun_fang@foxitsoftware.com

[Tom Sepez, 2014-08-25 19:26:28]

Jun, please review.

[jun_fang, 2014-08-25 19:44:04]

https://codereview.chromium.org/501823003/diff/20001/core/src/fpdfapi/fpdf_pa...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/501823003/diff/20001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:161: if
(!m_Syntax.GetCharAt(5, ch) || ch < '0' || ch > '9') {
This is used to parse file version which is not important information. Even it's
invalid, we shouldn't need to block the further parsing. So it's better to keep
it no change.

[Tom Sepez, 2014-08-25 20:05:32]

Please check ps#4.  Thanks.

https://codereview.chromium.org/501823003/diff/20001/core/src/fpdfapi/fpdf_pa...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/501823003/diff/20001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:161: if
(!m_Syntax.GetCharAt(5, ch) || ch < '0' || ch > '9') {
On 2014/08/25 19:44:04, jun_fang wrote:
> This is used to parse file version which is not important information. Even
it's
> invalid, we shouldn't need to block the further parsing. So it's better to
keep
> it no change. 
Ok.  I'll keep going but ingore out-of-range values, then.

[Tom Sepez, 2014-08-25 20:07:36]

Make that #5

[jun_fang, 2014-08-25 20:59:50]

On 2014/08/25 20:07:36, Tom Sepez wrote:
> Make that #5

LGTM. Thanks!

[Tom Sepez, 2014-08-25 21:59:08]

Committed patchset #5 manually as a3c7215 (presubmit successful).