tools/perf/metrics/power.py - Issue 501813002: [Telemetry] Fix idle wakeup reporting in the face of dead processes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/power.py

Issue 501813002: [Telemetry] Fix idle wakeup reporting in the face of dead processes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix cpu_stats comment. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/mac_platform_backend.py » ('j') | tools/telemetry/telemetry/core/platform/process_statistic_timeline_data.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/metrics/power.py

diff --git a/tools/perf/metrics/power.py b/tools/perf/metrics/power.py

index c871b1dd9fc908fdb3a0cd8eb44908cf802c75cb..0d10aa4c72fdf035acd8cdff973ec18175507d23 100644

--- a/tools/perf/metrics/power.py

+++ b/tools/perf/metrics/power.py

@@ -5,6 +5,7 @@

import time

from metrics import Metric

+from telemetry.core.platform import process_statistic_timeline_data

from telemetry.value import scalar

@@ -178,7 +179,10 @@ def _SubtractCpuStats(cpu_stats, start_cpu_stats):

if (('IdleWakeupCount' not in cpu_stats[process_type]) or

('IdleWakeupCount' not in start_cpu_stats[process_type])):

continue

+ assert isinstance(cpu_stats[process_type]['IdleWakeupCount'],

+ process_statistic_timeline_data.IdleWakeupTimelineData)

idle_wakeup_delta = (cpu_stats[process_type]['IdleWakeupCount'] -

start_cpu_stats[process_type]['IdleWakeupCount'])

- cpu_delta[process_type] = idle_wakeup_delta

+ cpu_delta[process_type] = idle_wakeup_delta.total_sum()

return cpu_delta