[webcrypto] Refactor to allow for unspecified "algorithm" to importKey().

[webcrypto] Refactor to allow for unspecified "algorithm" to importKey().

BUG=245025
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232003

[eroman, 2013-10-29 01:57:54]

Rather than add yet another out-parameter to ImportKeyInternal (for the
algorithm), I replaced them with a WebCryptoKey.

[padolph, 2013-10-29 23:12:33]

lgtm

[padolph, 2013-10-29 23:13:43]

lgtm

[commit-bot: I haz the power, 2013-10-30 20:41:48]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ryan Sleevi, 2013-10-30 20:55:52]

lgtm

https://codereview.chromium.org/50173002/diff/70001/content/renderer/webcrypt...
File content/renderer/webcrypto/webcrypto_impl.cc (right):

https://codereview.chromium.org/50173002/diff/70001/content/renderer/webcrypt...
content/renderer/webcrypto/webcrypto_impl.cc:104: result.completeWithError();
Should you follow the normal error form here?

if (!GenerateKeyInternal(...)) {
  error
}
success

https://codereview.chromium.org/50173002/diff/70001/content/renderer/webcrypt...
content/renderer/webcrypto/webcrypto_impl.cc:129: result.completeWithError();
ditto. Why change from the original form?

[eroman, 2013-10-30 21:26:21]

https://codereview.chromium.org/50173002/diff/70001/content/renderer/webcrypt...
File content/renderer/webcrypto/webcrypto_impl.cc (right):

https://codereview.chromium.org/50173002/diff/70001/content/renderer/webcrypt...
content/renderer/webcrypto/webcrypto_impl.cc:104: result.completeWithError();
On 2013/10/30 20:55:53, Ryan Sleevi wrote:
> Should you follow the normal error form here?
> 
> if (!GenerateKeyInternal(...)) {
>   error
> }
> success

Done.

https://codereview.chromium.org/50173002/diff/70001/content/renderer/webcrypt...
content/renderer/webcrypto/webcrypto_impl.cc:129: result.completeWithError();
On 2013/10/30 20:55:53, Ryan Sleevi wrote:
> ditto. Why change from the original form?

Done.

[commit-bot: I haz the power, 2013-10-30 22:11:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/50173002/210001

[commit-bot: I haz the power, 2013-10-31 04:33:36]

Change committed as 232003