Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: content/browser/loader/resource_scheduler.cc

Issue 501703002: Hook up loading signal to ResourceScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zhen_visibility
Patch Set: Removed unused testing function. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_scheduler.cc
diff --git a/content/browser/loader/resource_scheduler.cc b/content/browser/loader/resource_scheduler.cc
index 3519b8bdf8a4c4c9a6230912cb5dd83136222043..0d54b7b106d7e93ab0c8837a5ed3f17bcaa91090 100644
--- a/content/browser/loader/resource_scheduler.cc
+++ b/content/browser/loader/resource_scheduler.cc
@@ -288,7 +288,7 @@ class ResourceScheduler::Client {
bool is_loaded() const { return is_loaded_; }
- bool IsVisible() const { return is_visible_; }
+ bool is_visible() const { return is_visible_; }
void OnAudibilityChanged(bool is_audible) {
if (is_audible == is_audible_) {
@@ -821,6 +821,22 @@ void ResourceScheduler::OnClientDeleted(int child_id, int route_id) {
client_map_.erase(it);
}
+void ResourceScheduler::OnVisibilityChanged(int child_id,
+ int route_id,
+ bool is_visible) {
+ Client* client = GetClient(child_id, route_id);
+ DCHECK(client);
+ client->OnVisibilityChanged(is_visible);
+}
+
+void ResourceScheduler::OnLoadingStateChanged(int child_id,
+ int route_id,
+ bool is_loaded) {
+ Client* client = GetClient(child_id, route_id);
+ DCHECK(client);
+ client->OnLoadingStateChanged(is_loaded);
+}
+
void ResourceScheduler::OnNavigate(int child_id, int route_id) {
DCHECK(CalledOnValidThread());
ClientId client_id = MakeClientId(child_id, route_id);
@@ -872,26 +888,10 @@ void ResourceScheduler::OnAudibilityChanged(int child_id,
client->OnAudibilityChanged(is_audible);
}
-void ResourceScheduler::OnVisibilityChanged(int child_id,
- int route_id,
- bool is_visible) {
- Client* client = GetClient(child_id, route_id);
- DCHECK(client);
- client->OnVisibilityChanged(is_visible);
-}
-
-void ResourceScheduler::OnLoadingStateChanged(int child_id,
- int route_id,
- bool is_loaded) {
- Client* client = GetClient(child_id, route_id);
- DCHECK(client);
- client->OnLoadingStateChanged(is_loaded);
-}
-
bool ResourceScheduler::IsClientVisibleForTesting(int child_id, int route_id) {
Client* client = GetClient(child_id, route_id);
DCHECK(client);
- return client->IsVisible();
+ return client->is_visible();
}
ResourceScheduler::Client* ResourceScheduler::GetClient(int child_id,

Powered by Google App Engine
This is Rietveld 408576698