Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: content/browser/loader/resource_scheduler.h

Issue 501703002: Hook up loading signal to ResourceScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zhen_visibility
Patch Set: Move definitions to match declarations. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_scheduler.h
diff --git a/content/browser/loader/resource_scheduler.h b/content/browser/loader/resource_scheduler.h
index 8d0efc5155c4b8aad81770b635a5ae8652e60766..da5cd06233a535673ed907891d32b1054aeacf97 100644
--- a/content/browser/loader/resource_scheduler.h
+++ b/content/browser/loader/resource_scheduler.h
@@ -116,6 +116,12 @@ class CONTENT_EXPORT ResourceScheduler : public base::NonThreadSafe {
// Called when a renderer is destroyed.
void OnClientDeleted(int child_id, int route_id);
+ // Called when a renderer stops or restarts loading.
+ void OnLoadingStateChanged(int child_id, int route_id, bool is_loaded);
+
+ // Called when a Client is shown or hidden.
+ void OnVisibilityChanged(int child_id, int route_id, bool is_visible);
+
// Signals from IPC messages directly from the renderers:
// Called when a client navigates to a new main document.
@@ -139,13 +145,10 @@ class CONTENT_EXPORT ResourceScheduler : public base::NonThreadSafe {
// Called when a Client starts or stops playing audio.
void OnAudibilityChanged(int child_id, int route_id, bool is_audible);
- // Called when a Client is shown or hidden.
- void OnVisibilityChanged(int child_id, int route_id, bool is_visible);
-
- void OnLoadingStateChanged(int child_id, int route_id, bool is_loaded);
-
bool IsClientVisibleForTesting(int child_id, int route_id);
+ bool IsClientLoadedForTesting(int child_id, int route_id);
mmenke 2014/08/26 18:16:06 This isn't currently used - I'm fine with having t
aiolos (Not reviewing) 2014/08/26 18:28:28 It's easy enough to add back in if it ends up in t
+
private:
class RequestQueue;
class ScheduledResourceRequest;
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/loader/resource_scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698