Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: chrome/browser/chrome_plugin_interactive_test.cc

Issue 501633002: Disable WindowedNPAPIPluginHidden tests since they're flaky. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/star_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_plugin_interactive_test.cc
diff --git a/chrome/browser/chrome_plugin_interactive_test.cc b/chrome/browser/chrome_plugin_interactive_test.cc
index ff8169a0746855d81f9cc144326a1ba1f3515f79..0967d5879127909ab5f3ce05fee313ea1f3adea8 100644
--- a/chrome/browser/chrome_plugin_interactive_test.cc
+++ b/chrome/browser/chrome_plugin_interactive_test.cc
@@ -54,7 +54,8 @@ typedef InProcessBrowserTest ChromePluginTest;
// Test that if a background tab loads an NPAPI plugin, they are displayed after
// switching to that page. http://crbug.com/335900
-IN_PROC_BROWSER_TEST_F(ChromePluginTest, WindowedNPAPIPluginHidden) {
+// flaky: http://crbug.com/406631
+IN_PROC_BROWSER_TEST_F(ChromePluginTest, DISABLED_WindowedNPAPIPluginHidden) {
browser()->profile()->GetPrefs()->SetBoolean(prefs::kPluginsAlwaysAuthorize,
true);
@@ -103,7 +104,8 @@ typedef InProcessBrowserTest PrintPreviewTest;
// This test verifies that constrained windows aren't covered by windowed NPAPI
// plugins. The code which fixes this is in WebContentsViewAura::WindowObserver.
-IN_PROC_BROWSER_TEST_F(PrintPreviewTest, WindowedNPAPIPluginHidden) {
+// flaky: http://crbug.com/406631
+IN_PROC_BROWSER_TEST_F(PrintPreviewTest, DISABLED_WindowedNPAPIPluginHidden) {
browser()->profile()->GetPrefs()->SetBoolean(prefs::kPluginsAlwaysAuthorize,
true);
@@ -170,7 +172,9 @@ void EnsureFindBoxOpen(Browser* browser) {
}
// Ensure that the find bar is always over a windowed NPAPI plugin.
-IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, WindowedNPAPIPluginHidden) {
+// flaky: http://crbug.com/406631
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
+ DISABLED_WindowedNPAPIPluginHidden) {
chrome::DisableFindBarAnimationsDuringTesting(true);
browser()->profile()->GetPrefs()->SetBoolean(prefs::kPluginsAlwaysAuthorize,
true);
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/star_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698