Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 501623002: Adds necessary dependencies for view_manager tests (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Adds necessary dependencies for view_manager tests Otherwise if you just build mojo_view_manager_unittests on windows nothing works. BUG=none TEST=none R=jamesr@chromium.org Committed: https://crrev.com/7ac4254ef6df0dd3e108dfd35757fc3819a7acba Cr-Commit-Position: refs/heads/master@{#291574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/mojo_services.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
6 years, 4 months ago (2014-08-22 23:27:37 UTC) #1
jamesr
lgtm
6 years, 4 months ago (2014-08-22 23:33:57 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-22 23:34:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/501623002/1
6 years, 4 months ago (2014-08-22 23:34:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-23 05:18:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 6b7e7c2ef2c7fb9f70bd68da85cca099d2cb5791
6 years, 4 months ago (2014-08-23 19:49:25 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:30:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ac4254ef6df0dd3e108dfd35757fc3819a7acba
Cr-Commit-Position: refs/heads/master@{#291574}

Powered by Google App Engine
This is Rietveld 408576698