Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Unified Diff: runtime/bin/vmservice/observatory/deployed/web/index.html

Issue 501583007: Treat null like the object it is in the Observatory and Service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: sync and build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice/observatory/deployed/web/index_devtools.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/observatory/deployed/web/index.html
diff --git a/runtime/bin/vmservice/observatory/deployed/web/index.html b/runtime/bin/vmservice/observatory/deployed/web/index.html
index 7fd447db601f084a42c4af8c0cd2b350bb4ad983..2f72a5e86831f699ff12a356fa1e300fc92e4a01 100644
--- a/runtime/bin/vmservice/observatory/deployed/web/index.html
+++ b/runtime/bin/vmservice/observatory/deployed/web/index.html
@@ -920,30 +920,31 @@ hr {
}
</style>
<span>
- <template if="{{ isError(ref.serviceType) }}">
- <pre class="errorBox">{{ ref.message }}</pre>
+ <template if="{{ isError(ref) }}">
+ <pre class="errorBox">{{ ref.message }}</pre>
</template>
- <template if="{{ isUnexpected(ref.serviceType) }}">
+ <template if="{{ isUnexpected(ref) }}">
unexpected reference type &lt;{{ ref.serviceType }}&gt;
</template>
- <template if="{{ isNull(ref.serviceType) }}">
+ <template if="{{ isPsuedoNull(ref) }}">
<div title="{{ hoverText }}">{{ ref['valueAsString'] }}</div>
</template>
- <template if="{{ (isString(ref.serviceType) ||
- isBool(ref.serviceType) ||
- isInt(ref.serviceType)) ||
- isDouble(ref.serviceType)) }}">
+ <template if="{{ (isString(ref) ||
+ isBool(ref) ||
+ isNull(ref) ||
+ isInt(ref)) ||
+ isDouble(ref)) }}">
<a on-click="{{ goto }}" href="{{ url }}">{{ ref['valueAsString'] }}</a>
</template>
- <template if="{{ (isType(ref.serviceType)) }}">
+ <template if="{{ (isType(ref)) }}">
<a on-click="{{ goto }}" href="{{ url }}">{{ ref['user_name'] }}</a>
</template>
- <template if="{{ isInstance(ref.serviceType) &amp;&amp;
+ <template if="{{ isInstance(ref) &amp;&amp;
ref['closureFunc'] != null}}">
<a on-click="{{ goto }}" href="{{ url }}">
<!-- TODO(turnidge): Switch this to fully-qualified function -->
@@ -951,7 +952,7 @@ hr {
</a>
</template>
- <template if="{{ isInstance(ref.serviceType) &amp;&amp;
+ <template if="{{ isInstance(ref) &amp;&amp;
ref['closureFunc'] == null}}">
<a on-click="{{ goto }}" href="{{ url }}"><em>{{ ref['class'].name }}</em></a>
<curly-block callback="{{ expander() }}">
@@ -970,7 +971,7 @@ hr {
</curly-block>
</template>
- <template if="{{ isList(ref.serviceType) }}">
+ <template if="{{ isList(ref) }}">
<a on-click="{{ goto }}" href="{{ url }}"><em>{{ ref['class'].name }}</em> ({{ ref['length']}})</a>
<curly-block callback="{{ expander() }}">
<div class="memberList">
@@ -989,6 +990,7 @@ hr {
</template>
</polymer-element>
+
<polymer-element name="action-link">
<template>
<style>
@@ -14236,17 +14238,6 @@ hr {
word-wrap: break-word;
}
</style>
- <style>
- .errorBox {
- background-color: #f5f5f5;
- border: 1px solid #ccc;
- padding: 10px;
- font-family: consolas, courier, monospace;
- font-size: 1em;
- line-height: 1.2em;
- white-space: pre;
- }
- </style>
<div>
from <any-service-ref ref="{{ source }}"></any-service-ref>
<template if="{{ slotIsArrayIndex }}">via [{{ slot }}]</template>
« no previous file with comments | « no previous file | runtime/bin/vmservice/observatory/deployed/web/index_devtools.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698