runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart - Issue 501583007: Treat null like the object it is in the Observatory and Service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

Issue 501583007: Treat null like the object it is in the Observatory and Service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: sync and build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart ('k') | runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

index bda75071d00c1772632e54a51ef2d1ab90805c84..466799dfe8f68f53ee6171e8b9a6b7fa0aa7e217 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

@@ -86,17 +86,18 @@ class AnyServiceRefElement extends ObservatoryElement {

ServiceRefElement element = new Element.tag('library-ref');

element.ref = ref;

return element;

- case 'Type':

case 'Array':

+ case 'Bigint':

case 'Bool':

case 'Closure':

case 'Double':

case 'GrowableObjectArray':

case 'Instance':

- case 'Smi':

case 'Mint':

- case 'Bigint':

+ case 'Null':

+ case 'Smi':

case 'String':

+ case 'Type':

ServiceRefElement element = new Element.tag('instance-ref');

element.ref = ref;

return element;