Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1706)

Unified Diff: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html

Issue 501583007: Treat null like the object it is in the Observatory and Service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: sync and build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html
diff --git a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html
index efb70402d5785dd73be2d21f1f56619335f68f27..be0893ce00f33c6b38bb550e59581f7fc67a63d4 100644
--- a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html
+++ b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html
@@ -18,30 +18,31 @@
}
</style>
<span>
- <template if="{{ isError(ref.serviceType) }}">
- <pre class="errorBox">{{ ref.message }}</pre>
+ <template if="{{ isError(ref) }}">
+ <pre class="errorBox">{{ ref.message }}</pre>
</template>
- <template if="{{ isUnexpected(ref.serviceType) }}">
+ <template if="{{ isUnexpected(ref) }}">
unexpected reference type &lt;{{ ref.serviceType }}&gt;
</template>
- <template if="{{ isNull(ref.serviceType) }}">
+ <template if="{{ isPsuedoNull(ref) }}">
<div title="{{ hoverText }}">{{ ref['valueAsString'] }}</div>
</template>
- <template if="{{ (isString(ref.serviceType) ||
- isBool(ref.serviceType) ||
- isInt(ref.serviceType)) ||
- isDouble(ref.serviceType)) }}">
+ <template if="{{ (isString(ref) ||
+ isBool(ref) ||
+ isNull(ref) ||
+ isInt(ref)) ||
+ isDouble(ref)) }}">
<a on-click="{{ goto }}" href="{{ url }}">{{ ref['valueAsString'] }}</a>
</template>
- <template if="{{ (isType(ref.serviceType)) }}">
+ <template if="{{ (isType(ref)) }}">
<a on-click="{{ goto }}" href="{{ url }}">{{ ref['user_name'] }}</a>
</template>
- <template if="{{ isInstance(ref.serviceType) &&
+ <template if="{{ isInstance(ref) &&
ref['closureFunc'] != null}}">
<a on-click="{{ goto }}" href="{{ url }}">
<!-- TODO(turnidge): Switch this to fully-qualified function -->
@@ -49,7 +50,7 @@
</a>
</template>
- <template if="{{ isInstance(ref.serviceType) &&
+ <template if="{{ isInstance(ref) &&
ref['closureFunc'] == null}}">
<a on-click="{{ goto }}" href="{{ url }}"><em>{{ ref['class'].name }}</em></a>
<curly-block callback="{{ expander() }}">
@@ -68,7 +69,7 @@
</curly-block>
</template>
- <template if="{{ isList(ref.serviceType) }}">
+ <template if="{{ isList(ref) }}">
<a on-click="{{ goto }}" href="{{ url }}"><em>{{ ref['class'].name }}</em> ({{ ref['length']}})</a>
<curly-block callback="{{ expander() }}">
<div class="memberList">
@@ -87,4 +88,4 @@
</template>
</polymer-element>
-<script type="application/dart" src="instance_ref.dart"></script>
+<script type="application/dart" src="instance_ref.dart"></script>

Powered by Google App Engine
This is Rietveld 408576698