Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: runtime/vm/service_test.cc

Issue 501583007: Treat null like the object it is in the Observatory and Service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: sync and build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_test.cc
diff --git a/runtime/vm/service_test.cc b/runtime/vm/service_test.cc
index 147a3affa5e0ddad128106f2d472cfa671c5f985..5a0f5b260878e2cabb56fee94a6a17d60e79e759 100644
--- a/runtime/vm/service_test.cc
+++ b/runtime/vm/service_test.cc
@@ -523,9 +523,9 @@ TEST_CASE(Service_Objects) {
Service::HandleIsolateMessage(isolate, service_msg);
handler.HandleNextMessage();
handler.filterMsg("vmName");
- EXPECT_STREQ(
+ EXPECT_SUBSTRING(
"{\"type\":\"Null\",\"id\":\"objects\\/null\","
- "\"valueAsString\":\"null\"}",
+ "\"valueAsString\":\"null\",\"class\":",
handler.msg());
// not initialized
@@ -1101,7 +1101,8 @@ TEST_CASE(Service_Classes) {
ExpectSubstringF(handler.msg(), "\"id\":\"objects\\/%" Pd "\",\"length\":2",
kInstanceListId);
Array& list = Array::Handle();
- list ^= isolate->object_id_ring()->GetObjectForId(kInstanceListId);
+ ObjectIdRing::LookupResult kind;
+ list ^= isolate->object_id_ring()->GetObjectForId(kInstanceListId, &kind);
EXPECT_EQ(2, list.Length());
// The list should contain {b0, b1}.
EXPECT((list.At(0) == b0.raw() && list.At(1) == b1.raw()) ||
@@ -1324,9 +1325,9 @@ TEST_CASE(Service_Code) {
address);
Service::HandleIsolateMessage(isolate, service_msg);
handler.HandleNextMessage();
- EXPECT_STREQ("{\"type\":\"Null\",\"id\":\"objects\\/null\","
- "\"valueAsString\":\"null\"}",
- handler.msg());
+ EXPECT_SUBSTRING("{\"type\":\"Null\",\"id\":\"objects\\/null\","
+ "\"valueAsString\":\"null\"",
+ handler.msg());
// Request malformed native code.
service_msg = EvalF(lib, "[0, port, ['code', 'native%" Px "'], [], []]",
« no previous file with comments | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698