content/browser/web_contents/web_contents_view_android.cc - Issue 501583003: Move external popup menus from WebViewClient to WebFrameClient, part 3/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_android.cc

Issue 501583003: Move external popup menus from WebViewClient to WebFrameClient, part 3/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nicer ipc Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/web_contents/web_contents_view_android.h ('k') | content/browser/web_contents/web_contents_view_mac.h » ('j') | content/renderer/render_frame_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_android.cc

diff --git a/content/browser/web_contents/web_contents_view_android.cc b/content/browser/web_contents/web_contents_view_android.cc

index 3378595be7ede7dac3f63068703d30b3972a54c7..58ed0efba8879f175e21c498f6677ddd175c0d5f 100644

--- a/content/browser/web_contents/web_contents_view_android.cc

+++ b/content/browser/web_contents/web_contents_view_android.cc

@@ -163,6 +163,7 @@ void WebContentsViewAndroid::ShowContextMenu(

}

void WebContentsViewAndroid::ShowPopupMenu(

+ RenderFrameHost* render_frame_host,

const gfx::Rect& bounds,

int item_height,

double item_font_size,

@@ -171,8 +172,11 @@ void WebContentsViewAndroid::ShowPopupMenu(

bool right_aligned,

bool allow_multiple_selection) {

if (content_view_core_) {

- content_view_core_->ShowSelectPopupMenu(

- bounds, items, selected_item, allow_multiple_selection);

+ content_view_core_->ShowSelectPopupMenu(render_frame_host,

+ bounds,

+ items,

+ selected_item,

+ allow_multiple_selection);

}