content/browser/frame_host/interstitial_page_impl.cc - Issue 501583003: Move external popup menus from WebViewClient to WebFrameClient, part 3/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 501583003: Move external popup menus from WebViewClient to WebFrameClient, part 3/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nicer ipc Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm ('k') | content/browser/frame_host/popup_menu_helper_mac.h » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/interstitial_page_impl.cc

diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc

index f2cac9c96e77496710d2e3b4e87a74395e8e4796..f2ce0ea15787814d702905c97566b721da2ad808 100644

--- a/content/browser/frame_host/interstitial_page_impl.cc

+++ b/content/browser/frame_host/interstitial_page_impl.cc

@@ -78,7 +78,8 @@ class InterstitialPageImpl::InterstitialPageRVHDelegateView

// RenderViewHostDelegateView implementation:

#if defined(OS_MACOSX) || defined(OS_ANDROID)

- virtual void ShowPopupMenu(const gfx::Rect& bounds,

+ virtual void ShowPopupMenu(RenderFrameHost* render_frame_host,

+ const gfx::Rect& bounds,

int item_height,

double item_font_size,

int selected_item,

@@ -863,6 +864,7 @@ InterstitialPageImpl::InterstitialPageRVHDelegateView::

#if defined(OS_MACOSX) || defined(OS_ANDROID)

void InterstitialPageImpl::InterstitialPageRVHDelegateView::ShowPopupMenu(

+ RenderFrameHost* render_frame_host,

const gfx::Rect& bounds,

int item_height,

double item_font_size,