Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: content/renderer/render_frame_impl.h

Issue 501583003: Move external popup menus from WebViewClient to WebFrameClient, part 3/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/external_popup_menu_browsertest.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 309ef080afc005a01de312298fd1b8a0ac6ece0b..08d5b336bee49ee8e6b183aee814bf1c0698aca8 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -37,8 +37,6 @@ class TransportDIB;
struct FrameMsg_Navigate_Params;
namespace blink {
-class WebExternalPopupMenu;
-class WebExternalPopupMenuClient;
class WebGeolocationClient;
class WebInputEvent;
class WebMouseEvent;
@@ -50,7 +48,6 @@ class WebSecurityOrigin;
struct WebCompositionUnderline;
struct WebContextMenuData;
struct WebCursorInfo;
-struct WebPopupMenuInfo;
}
namespace gfx {
@@ -62,6 +59,7 @@ class Rect;
namespace content {
class ChildFrameCompositingHelper;
+class ExternalPopupMenu;
class GeolocationDispatcher;
class MediaStreamDispatcher;
class MediaStreamImpl;
@@ -238,6 +236,10 @@ class CONTENT_EXPORT RenderFrameImpl
// NULL.
MediaStreamDispatcher* GetMediaStreamDispatcher();
+#if defined(OS_MACOSX) || defined(OS_ANDROID)
+ void DidHideExternalPopupMenu();
+#endif
+
// IPC::Sender
virtual bool Send(IPC::Message* msg) OVERRIDE;
@@ -456,6 +458,10 @@ class CONTENT_EXPORT RenderFrameImpl
private:
friend class RenderFrameObserver;
friend class RendererAccessibilityTest;
+ FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuDisplayNoneTest, SelectItem);
+ FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuRemoveTest, RemoveOnChange);
+ FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuTest, NormalCase);
+ FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuTest, ShowPopupThenNavigate);
FRIEND_TEST_ALL_PREFIXES(RendererAccessibilityTest,
AccessibilityMessagesQueueWhileSwappedOut);
FRIEND_TEST_ALL_PREFIXES(RenderFrameImplTest,
@@ -521,7 +527,11 @@ class CONTENT_EXPORT RenderFrameImpl
void OnBeginExitTransition(const std::string& css_selector);
void OnSetAccessibilityMode(AccessibilityMode new_mode);
void OnDisownOpener();
-#if defined(OS_MACOSX)
+#if defined(OS_ANDROID)
+ void OnSelectPopupMenuItems(bool canceled,
+ const std::vector<int>& selected_indices);
+#elif defined(OS_MACOSX)
+ void OnSelectPopupMenuItem(int selected_index);
void OnCopyToFindPboard();
#endif
@@ -715,6 +725,11 @@ class CONTENT_EXPORT RenderFrameImpl
// AccessibilityModeOff.
RendererAccessibility* renderer_accessibility_;
+#if defined(OS_MACOSX) || defined(OS_ANDROID)
+ // The external popup for the currently showing select popup.
+ scoped_ptr<ExternalPopupMenu> external_popup_menu_;
+#endif
+
base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
« no previous file with comments | « content/renderer/external_popup_menu_browsertest.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698