Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 501563002: Don't leak the shader by reffing twice in SkRectShaderImageFilter. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
bsalomon, mtklein, reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't leak the shader by reffing twice in SkRectShaderImageFilter. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b00f54d8b8365a398d7a745c6105d441a7429418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/effects/SkRectShaderImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 4 months ago (2014-08-22 20:34:31 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-22 20:35:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/501563002/1
6 years, 4 months ago (2014-08-22 20:36:25 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-22 20:36:26 UTC) #4
bsalomon
lgtm
6 years, 4 months ago (2014-08-22 20:36:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as b00f54d8b8365a398d7a745c6105d441a7429418
6 years, 4 months ago (2014-08-22 20:43:02 UTC) #6
reed2
thanks
6 years, 4 months ago (2014-08-23 01:52:44 UTC) #7
reed2
6 years, 4 months ago (2014-08-23 01:52:45 UTC) #8
Message was sent while issue was closed.
thanks

Powered by Google App Engine
This is Rietveld 408576698