Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 501553005: Scale invocation count by the number of BBs in the flow-graph of a method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_mips.cc
diff --git a/runtime/vm/flow_graph_compiler_mips.cc b/runtime/vm/flow_graph_compiler_mips.cc
index aa3d0c15988e681153a91c2c10ed15a94864f2f6..76db1c3f42ed92c8796d13c4f329fc9176932c21 100644
--- a/runtime/vm/flow_graph_compiler_mips.cc
+++ b/runtime/vm/flow_graph_compiler_mips.cc
@@ -22,8 +22,6 @@
namespace dart {
DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization.");
-DECLARE_FLAG(int, optimization_counter_threshold);
-DECLARE_FLAG(int, reoptimization_counter_threshold);
DECLARE_FLAG(bool, enable_type_checks);
@@ -1008,20 +1006,17 @@ void FlowGraphCompiler::EmitFrameEntry() {
// Patch point is after the eventually inlined function object.
entry_patch_pc_offset_ = assembler()->CodeSize();
- intptr_t threshold = FLAG_optimization_counter_threshold;
__ lw(T1, FieldAddress(function_reg, Function::usage_counter_offset()));
- if (is_optimizing()) {
- // Reoptimization of an optimized function is triggered by counting in
- // IC stubs, but not at the entry of the function.
- threshold = FLAG_reoptimization_counter_threshold;
- } else {
+ // Reoptimization of an optimized function is triggered by counting in
+ // IC stubs, but not at the entry of the function.
+ if (!is_optimizing()) {
__ addiu(T1, T1, Immediate(1));
__ sw(T1, FieldAddress(function_reg, Function::usage_counter_offset()));
}
// Skip Branch if T1 is less than the threshold.
Label dont_branch;
- __ BranchSignedLess(T1, threshold, &dont_branch);
+ __ BranchSignedLess(T1, GetOptimizationThreshold(), &dont_branch);
ASSERT(function_reg == T0);
__ Branch(&stub_code->OptimizeFunctionLabel());
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698