Chromium Code Reviews| Index: ui/events/gesture_detection/gesture_provider.cc |
| diff --git a/ui/events/gesture_detection/gesture_provider.cc b/ui/events/gesture_detection/gesture_provider.cc |
| index c76460e53c63da200bda0dcf3cec80946e79fd0a..9c93ea200e91424408b6b02f87945746e90a0689 100644 |
| --- a/ui/events/gesture_detection/gesture_provider.cc |
| +++ b/ui/events/gesture_detection/gesture_provider.cc |
| @@ -265,6 +265,9 @@ class GestureProvider::GestureListenerImpl |
| }; |
| client_->OnGestureEvent(gesture); |
| + // Record and generate the gesture UMA histograms for all platforms. |
|
tdresser
2014/08/27 12:35:38
I think the method name is probably descriptive en
lanwei
2014/08/27 23:31:59
Done.
|
| + GestureTouchUMAHistogram umaHistogram; |
|
tdresser
2014/08/27 12:35:38
Why are you instantiating a new instance of Gestur
lanwei
2014/08/27 23:31:59
The send function does not know uma_histogram_. As
|
| + umaHistogram.RecordGestureEvent(gesture); |
| } |
| // ScaleGestureDetector::ScaleGestureListener implementation. |
| @@ -656,6 +659,8 @@ bool GestureProvider::OnTouchEvent(const MotionEvent& event) { |
| OnTouchEventHandlingBegin(event); |
| gesture_listener_->OnTouchEvent(event); |
| OnTouchEventHandlingEnd(event); |
| + // Record and generate the touch UMA histograms for all platforms. |
|
tdresser
2014/08/27 12:35:38
Comment is unnecessary.
lanwei
2014/08/27 23:31:59
Done.
|
| + umaHistogram.RecordTouchEvent(event); |
| return true; |
| } |