Chromium Code Reviews Chromium Code Reviews
Issue 501553004:
Move gesture/touch UMA logs into gesture provider (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 6c8b87981dc357d635412a95432d0ac958d174fa..f0f2db91ad938e3ba6a2af4d93b49454d005a269 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -595,6 +595,9 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </histogram> |
| <histogram name="Ash.GestureCreated" enum="UIEventType"> |
| + <obsolete> |
| + Deprecated 08/2014 in Issue 352654, and replaced by Event.GestureCreated. |
| + </obsolete> |
| <owner>kuscher@google.com</owner> |
| <owner>rbyers@chromium.org</owner> |
| <summary> |
| @@ -649,12 +652,18 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </histogram> |
| <histogram name="Ash.TouchDuration2" units="milliseconds"> |
| + <obsolete> |
| + Deprecated 08/2014 in Issue 352654, and replaced by Event.TouchDuration2. |
|
tdresser
2014/08/28 12:47:50
We can just name this Event.TouchDuration (without
lanwei
2014/08/28 18:12:15
Done.
|
| + </obsolete> |
| <owner>kuscher@google.com</owner> |
| <owner>rbyers@chromium.org</owner> |
| <summary>The duration of a touch-sequence.</summary> |
| </histogram> |
| <histogram name="Ash.TouchMaxDistance" units="pixels"> |
| + <obsolete> |
| + Deprecated 08/2014 in Issue 352654, and replaced by Event.TouchMaxDistance. |
| + </obsolete> |
| <owner>kuscher@google.com</owner> |
| <owner>rbyers@chromium.org</owner> |
| <summary> |
| @@ -6236,6 +6245,16 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Event.GestureCreated" enum="UIEventType"> |
| + <owner>kuscher@google.com</owner> |
| + <owner>rbyers@chromium.org</owner> |
| + <summary> |
| + The gesture-events recognized and dispatched by the browser gesture |
| + recognizer, a new version of Ash.GestureCreated, as it also records events |
|
tdresser
2014/08/28 12:47:50
It would be a bit clearer to say:
The gesture-even
lanwei
2014/08/28 18:12:15
Done.
|
| + from Android and Window. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Event.Latency.Browser" units="microseconds"> |
| <owner>rbyers@chromium.org</owner> |
| <summary> |
| @@ -6598,6 +6617,26 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Event.TouchDuration2" units="milliseconds"> |
| + <owner>kuscher@google.com</owner> |
| + <owner>rbyers@chromium.org</owner> |
| + <summary> |
| + The duration of a touch-sequence, a new version of Ash.TouchDuration2, as it |
| + also records events from Android and Window. |
|
tdresser
2014/08/28 12:47:50
Mention that this is only recorded for single fing
lanwei
2014/08/28 18:12:15
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Event.TouchMaxDistance" units="pixels"> |
| + <owner>kuscher@google.com</owner> |
| + <owner>rbyers@chromium.org</owner> |
| + <summary> |
| + The maximum euclidean distance in dips which a touch point has travelled |
| + away from its starting point. Only measured for single finger gestures, a |
| + new version of Ash.TouchMaxDistance, as it also records events from Android |
| + and Window. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="ExtensionActivity.AdInjected" units="Extension Count"> |
| <owner>felt@chromium.org</owner> |
| <owner>rdevlin.cronin@chromium.org</owner> |
| @@ -50631,6 +50670,7 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="33" label="Tap Cancel"/> |
| <int value="34" label="Edge swipe"/> |
| <int value="35" label="One-finger swipe"/> |
| + <int value="36" label="Tap unconfirmed"/> |
| </enum> |
| <enum name="UmaInitSequence" type="int"> |
