Issue 501533003: Support comment groups in SkRecord.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501533003: Support comment groups in SkRecord. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
Tom Hudson, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Support comment groups in SkRecord. This should fix the failing paint-command-log-nodes.html layout test. BUG=406425 Committed: https://skia.googlesource.com/skia/+/5f0e82204ecca0805a7689cdba5f802458e103f4

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -0 lines)			Patch
M	src/core/SkRecordDraw.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/core/SkRecorder.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/core/SkRecorder.cpp	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/core/SkRecords.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	tests/RecorderTest.cpp	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/501533003/20001

6 years, 4 months ago (2014-08-22 18:37:05 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 18:44:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (20001) as 5f0e82204ecca0805a7689cdba5f802458e103f4