Change these tests to actually trigger the execCommand from the iframe context.

Change these tests to actually trigger the execCommand from the iframe context.

BUG=395376
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291476

[Marijn Kruisselbrink, 2014-08-22 17:08:53]

Okay, this time these tests do actually fail after applying your CL.

[not at google - send to devlin, 2014-08-22 17:21:35]

lgtm, thanks for fixing that.

https://codereview.chromium.org/501513002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.js
(right):

https://codereview.chromium.org/501513002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.js:36:
if (window.command === 'paste') result = !result;
I find it hard to parse this out of context (bouncing off the that
document.write/iframe doesn't help). Perhaps add a comment or rephrase? It's a
little odd to be reversing the result like this. Perhaps phrase it in terms of
expected result?

// 'copy' should always succeed regardless of the kClipboardWrite permission,
// for backwards compatibility. 'paste' should always fail because the extension
// doesn't have kClipboardRead.
var expected = window.command === 'copy';
if (result != expected)
  ...

[Marijn Kruisselbrink, 2014-08-22 17:31:47]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-08-22 17:32:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mek@chromium.org/501513002/20001

[Marijn Kruisselbrink, 2014-08-22 17:40:34]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-08-22 17:41:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mek@chromium.org/501513002/40001

[commit-bot: I haz the power, 2014-08-22 18:46:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 19:37:15]

Committed patchset #3 (40001) as 291476