ui/events/gesture_detection/gesture_config_helper_aura.cc - Issue 501503003: Avoid an extra GestureDetector instance for double-tap drag zooming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/gesture_config_helper_aura.cc

Issue 501503003: Avoid an extra GestureDetector instance for double-tap drag zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/gesture_detection/gesture_config_helper_android.cc ('k') | ui/events/gesture_detection/gesture_provider.h » ('j') | ui/events/gesture_detection/scale_gesture_detector.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gesture_detection/gesture_config_helper_aura.cc

diff --git a/ui/events/gesture_detection/gesture_config_helper_aura.cc b/ui/events/gesture_detection/gesture_config_helper_aura.cc

index 195e891ed556bcae2ebdd30275294957974c3703..94469c502f02f486d8559996b5125f59321553f9 100644

--- a/ui/events/gesture_detection/gesture_config_helper_aura.cc

+++ b/ui/events/gesture_detection/gesture_config_helper_aura.cc

@@ -52,7 +52,8 @@ ScaleGestureDetector::Config DefaultScaleGestureDetectorConfig() {

? GestureConfiguration::min_pinch_update_distance_in_pixels()

: 0;

- config.gesture_detector_config = DefaultGestureDetectorConfig();

+ config.span_slop =

+ GestureConfiguration::max_touch_move_in_pixels_for_click() * 2;

config.min_scaling_touch_major = GestureConfiguration::default_radius() * 2;

config.min_scaling_span = GestureConfiguration::min_scaling_span_in_pixels();

config.min_pinch_update_span_delta = min_pinch_update_distance;