|
|
Created:
6 years, 4 months ago by Ignacio Solla Modified:
6 years, 3 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionFix a crash reported by monkey tests.
BUG=405504
Committed: https://crrev.com/0b0bc19551b54548a5653aed72084f8ce60b2019
Cr-Commit-Position: refs/heads/master@{#292359}
Patch Set 1 #
Messages
Total messages: 15 (0 generated)
benm@chromium.org changed reviewers: + aurimas@chromium.org
I'm not certain. You are now skipping a bunch of code that wasn't being skipped before. Maybe safest change would be to change the assert to handle null. +Aurimas are you familiar with this code path?
On 2014/08/26 10:49:47, benm wrote: > I'm not certain. You are now skipping a bunch of code that wasn't being skipped > before. Maybe safest change would be to change the assert to handle null. > > +Aurimas are you familiar with this code path? We're skipping the code that sets the LayoutParams for the anchor view. Once the anchor view has been released (when its parent is null) it will not be re-attached to the window so setting the layout params does not longer make sense. I think that we can safely assume that releasing the view is an irreversible mutation. I don't think that we should support callers (and I believe that there aren't any) that call releaseAnchorView() and then re-attach the anchor view by themselves as a child of some other view X (and this code is already broken if X != mContainerViewAtCreation anyway). The anchor view should only be attached to the window from acquireAnchorView().
lgtm
The CQ bit was checked by igsolla@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/501473002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by igsolla@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/501473002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 172a7e6b2e7c3c66c2240715d11392bd5da8017a
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0b0bc19551b54548a5653aed72084f8ce60b2019 Cr-Commit-Position: refs/heads/master@{#292359} |