Issue 501463003: Remove two unused prefs keys.

Issue 501463003: Remove two unused prefs keys. (Closed)

Created:
6 years, 4 months ago by dgrogan

Modified:
6 years, 3 months ago

Reviewers:
Bernhard Bauer, Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove two unused prefs keys. kKeywordEditorWindowPlacement, kPreferencesWindowPlacement haven't been used in a few years. Committed: https://crrev.com/d0e3a463b927708845f33a8d7102fc74723b6e37 Cr-Commit-Position: refs/heads/master@{#291760}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -23 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_ui_prefs.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/search_engines/keyword_editor_controller.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search_engines/keyword_editor_controller.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dgrogan

bauerb@, could you review this? I noticed they were unused while tackling http://crbug.com/167256

6 years, 4 months ago (2014-08-22 23:46:20 UTC) #1

dgrogan

+pkasting for chrome/browser/ui/browser_ui_prefs.cc chrome/browser/ui/search_engines/keyword_editor_controller.h chrome/browser/ui/search_engines/keyword_editor_controller.cc

6 years, 4 months ago (2014-08-25 17:26:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/501463003/1

6 years, 4 months ago (2014-08-25 20:19:52 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (1) as 6dff24a2ea3e51acfbed42ca7fb451914abb173a

6 years, 4 months ago (2014-08-25 21:11:55 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:37:32 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d0e3a463b927708845f33a8d7102fc74723b6e37
Cr-Commit-Position: refs/heads/master@{#291760}

Expand Messages | Collapse Messages