Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 501453002: Decouple script_url from ServiceWorkerRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync after major collision Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index b7515730582a00234f2791e4790f4beb52c2011b..abd8a4f4a59af7cfbbff57c16a3a76cede1b5729 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -494,11 +494,11 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
void SetUpRegistrationOnIOThread(const std::string& worker_url) {
registration_ = new ServiceWorkerRegistration(
embedded_test_server()->GetURL("/"),
- embedded_test_server()->GetURL(worker_url),
wrapper()->context()->storage()->NewRegistrationId(),
wrapper()->context()->AsWeakPtr());
version_ = new ServiceWorkerVersion(
registration_.get(),
+ embedded_test_server()->GetURL(worker_url),
wrapper()->context()->storage()->NewVersionId(),
wrapper()->context()->AsWeakPtr());
AssociateRendererProcessToWorker(version_->embedded_worker());
@@ -824,29 +824,23 @@ class ServiceWorkerBlackBoxBrowserTest : public ServiceWorkerBrowserTest {
void FindRegistrationOnIO(const GURL& document_url,
ServiceWorkerStatusCode* status,
- GURL* script_url,
const base::Closure& continuation) {
wrapper()->context()->storage()->FindRegistrationForDocument(
document_url,
base::Bind(&ServiceWorkerBlackBoxBrowserTest::FindRegistrationOnIO2,
this,
status,
- script_url,
continuation));
}
void FindRegistrationOnIO2(
ServiceWorkerStatusCode* out_status,
- GURL* script_url,
const base::Closure& continuation,
ServiceWorkerStatusCode status,
const scoped_refptr<ServiceWorkerRegistration>& registration) {
*out_status = status;
- if (registration.get()) {
- *script_url = registration->script_url();
- } else {
+ if (!registration.get())
EXPECT_NE(SERVICE_WORKER_OK, status);
- }
continuation.Run();
}
};
@@ -935,13 +929,11 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBlackBoxBrowserTest, MAYBE_Registration) {
// Should not be able to find it.
{
ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;
- GURL script_url;
RunOnIOThread(
base::Bind(&ServiceWorkerBlackBoxBrowserTest::FindRegistrationOnIO,
this,
embedded_test_server()->GetURL("/service_worker/empty.html"),
- &status,
- &script_url));
+ &status));
EXPECT_EQ(SERVICE_WORKER_ERROR_NOT_FOUND, status);
}
}

Powered by Google App Engine
This is Rietveld 408576698