Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: content/browser/service_worker/service_worker_storage_unittest.cc

Issue 501453002: Decouple script_url from ServiceWorkerRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_storage_unittest.cc
diff --git a/content/browser/service_worker/service_worker_storage_unittest.cc b/content/browser/service_worker/service_worker_storage_unittest.cc
index 209718109bf9a0d66877b667c27c440cead4aa24..e5522adddd53a11353df8ea348bd9fc92b17a2b6 100644
--- a/content/browser/service_worker/service_worker_storage_unittest.cc
+++ b/content/browser/service_worker/service_worker_storage_unittest.cc
@@ -350,10 +350,10 @@ TEST_F(ServiceWorkerStorageTest, StoreFindUpdateDeleteRegistration) {
// Store something.
scoped_refptr<ServiceWorkerRegistration> live_registration =
new ServiceWorkerRegistration(
- kScope, kScript, kRegistrationId, context_ptr_);
+ kScope, kRegistrationId, context_ptr_);
scoped_refptr<ServiceWorkerVersion> live_version =
new ServiceWorkerVersion(
- live_registration, kVersionId, context_ptr_);
+ live_registration, kScript, kVersionId, context_ptr_);
live_version->SetStatus(ServiceWorkerVersion::INSTALLED);
live_registration->SetWaitingVersion(live_version);
live_registration->set_last_update_check(kYesterday);
@@ -423,7 +423,7 @@ TEST_F(ServiceWorkerStorageTest, StoreFindUpdateDeleteRegistration) {
// Trying to update a unstored registration to active should fail.
scoped_refptr<ServiceWorkerRegistration> unstored_registration =
new ServiceWorkerRegistration(
- kScope, kScript, kRegistrationId + 1, context_ptr_);
+ kScope, kRegistrationId + 1, context_ptr_);
EXPECT_EQ(SERVICE_WORKER_ERROR_NOT_FOUND,
UpdateToActiveState(unstored_registration));
unstored_registration = NULL;
@@ -470,10 +470,10 @@ TEST_F(ServiceWorkerStorageTest, InstallingRegistrationsAreFindable) {
// Create an unstored registration.
scoped_refptr<ServiceWorkerRegistration> live_registration =
new ServiceWorkerRegistration(
- kScope, kScript, kRegistrationId, context_ptr_);
+ kScope, kRegistrationId, context_ptr_);
scoped_refptr<ServiceWorkerVersion> live_version =
new ServiceWorkerVersion(
- live_registration, kVersionId, context_ptr_);
+ live_registration, kScript, kVersionId, context_ptr_);
live_version->SetStatus(ServiceWorkerVersion::INSTALLING);
live_registration->SetWaitingVersion(live_version);
@@ -862,7 +862,7 @@ TEST_F(ServiceWorkerResourceStorageTest, UpdateRegistration) {
// Make an updated registration.
scoped_refptr<ServiceWorkerVersion> live_version = new ServiceWorkerVersion(
- registration_, storage()->NewVersionId(), context_ptr_);
+ registration_, script_, storage()->NewVersionId(), context_ptr_);
live_version->SetStatus(ServiceWorkerVersion::NEW);
registration_->SetWaitingVersion(live_version);
@@ -913,10 +913,10 @@ TEST_F(ServiceWorkerStorageTest, FindRegistration_LongestScopeMatch) {
const int64 kVersionId1 = 1;
scoped_refptr<ServiceWorkerRegistration> live_registration1 =
new ServiceWorkerRegistration(
- kScope1, kScript1, kRegistrationId1, context_ptr_);
+ kScope1, kRegistrationId1, context_ptr_);
scoped_refptr<ServiceWorkerVersion> live_version1 =
new ServiceWorkerVersion(
- live_registration1, kVersionId1, context_ptr_);
+ live_registration1, kScript1, kVersionId1, context_ptr_);
live_version1->SetStatus(ServiceWorkerVersion::INSTALLED);
live_registration1->SetWaitingVersion(live_version1);
@@ -927,10 +927,10 @@ TEST_F(ServiceWorkerStorageTest, FindRegistration_LongestScopeMatch) {
const int64 kVersionId2 = 2;
scoped_refptr<ServiceWorkerRegistration> live_registration2 =
new ServiceWorkerRegistration(
- kScope2, kScript2, kRegistrationId2, context_ptr_);
+ kScope2, kRegistrationId2, context_ptr_);
scoped_refptr<ServiceWorkerVersion> live_version2 =
new ServiceWorkerVersion(
- live_registration2, kVersionId2, context_ptr_);
+ live_registration2, kScript2, kVersionId2, context_ptr_);
live_version2->SetStatus(ServiceWorkerVersion::INSTALLED);
live_registration2->SetWaitingVersion(live_version2);
@@ -941,10 +941,10 @@ TEST_F(ServiceWorkerStorageTest, FindRegistration_LongestScopeMatch) {
const int64 kVersionId3 = 3;
scoped_refptr<ServiceWorkerRegistration> live_registration3 =
new ServiceWorkerRegistration(
- kScope3, kScript3, kRegistrationId3, context_ptr_);
+ kScope3, kRegistrationId3, context_ptr_);
scoped_refptr<ServiceWorkerVersion> live_version3 =
new ServiceWorkerVersion(
- live_registration3, kVersionId3, context_ptr_);
+ live_registration3, kScript3, kVersionId3, context_ptr_);
live_version3->SetStatus(ServiceWorkerVersion::INSTALLED);
live_registration3->SetWaitingVersion(live_version3);

Powered by Google App Engine
This is Rietveld 408576698