Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 50143013: Reapply 231888 "Fixes for python 2.7.5 support." with fixes. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Reapply 231888 "Fixes for python 2.7.5 support." with fixes. Tested to work now with the repro case of bug 313552. "/c" was interpreted by cygwin's bash as a path and was replaced with c:/. :( Using //c seems to be passed through properly. There is probably other escaping problem but this should be good enough at this stage. Ref: http://www.mingw.org/wiki/Posix_path_conversion R=iannucci@chromium.org BUG=241769 BUG=313552 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=232184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M git-cl View 1 chunk +2 lines, -2 lines 0 comments Download
M git-try View 1 chunk +2 lines, -2 lines 0 comments Download
M pylint View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
CYGWIIIIIIIIN!!!!!
7 years, 1 month ago (2013-10-31 18:51:08 UTC) #1
iannucci
On 2013/10/31 18:51:08, M-A Ruel wrote: > CYGWIIIIIIIIN!!!!! Ouch! Is there a setopt we can ...
7 years, 1 month ago (2013-10-31 18:57:40 UTC) #2
M-A Ruel
On 2013/10/31 18:57:40, iannucci wrote: > On 2013/10/31 18:51:08, M-A Ruel wrote: > > CYGWIIIIIIIIN!!!!! ...
7 years, 1 month ago (2013-10-31 18:59:23 UTC) #3
M-A Ruel
On 2013/10/31 18:59:23, M-A Ruel wrote: > On 2013/10/31 18:57:40, iannucci wrote: > > On ...
7 years, 1 month ago (2013-10-31 18:59:50 UTC) #4
iannucci
On 2013/10/31 18:59:50, M-A Ruel wrote: > On 2013/10/31 18:59:23, M-A Ruel wrote: > > ...
7 years, 1 month ago (2013-10-31 19:06:15 UTC) #5
M-A Ruel
On 2013/10/31 19:06:15, iannucci wrote: > Looks like there's no obvious way to turn it ...
7 years, 1 month ago (2013-10-31 19:08:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/50143013/1
7 years, 1 month ago (2013-10-31 19:08:36 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 19:10:57 UTC) #8
Message was sent while issue was closed.
Change committed as 232184

Powered by Google App Engine
This is Rietveld 408576698