Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 501413003: Remove implicit conversions from scoped_refptr to T* in components/data_reduction_proxy/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in components/data_reduction_proxy/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/900d3d42c0577b5a3d64858c6a02a1917fb78f71 Cr-Commit-Position: refs/heads/master@{#291934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection_unittest.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc View 10 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + marq@chromium.org
6 years, 3 months ago (2014-08-26 16:21:48 UTC) #1
dcheng
6 years, 3 months ago (2014-08-26 16:21:48 UTC) #2
marq (ping after 24h)
marq@chromium.org changed reviewers: + bengr@google.com
6 years, 3 months ago (2014-08-26 16:27:50 UTC) #3
marq (ping after 24h)
marq@chromium.org changed reviewers: - marq@chromium.org
6 years, 3 months ago (2014-08-26 16:28:44 UTC) #4
marq (ping after 24h)
marq@chromium.org changed reviewers: + marq@chromium.org
6 years, 3 months ago (2014-08-26 16:29:59 UTC) #5
marq (ping after 24h)
LGTM Ben, chime in if you have any objections, since this is a change to ...
6 years, 3 months ago (2014-08-26 16:29:59 UTC) #6
bengr
On 2014/08/26 16:29:59, marq_ wrote: > LGTM > > Ben, chime in if you have ...
6 years, 3 months ago (2014-08-26 16:31:38 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 16:32:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/501413003/1
6 years, 3 months ago (2014-08-26 16:33:04 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-26 17:15:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (1) as 71a45fcbe3d69241b408a60c4fe44c5e666ca23f
6 years, 3 months ago (2014-08-26 18:00:43 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/900d3d42c0577b5a3d64858c6a02a1917fb78f71
Cr-Commit-Position: refs/heads/master@{#291934}

Powered by Google App Engine
This is Rietveld 408576698