Componentize GoogleURLTracker unittest

components/infobars/test/infobar_test.cc

Index: components/infobars/test/infobar_test.cc
diff --git a/components/infobars/test/infobar_test.cc b/components/infobars/test/infobar_test.cc
index a2f17bb23a0809435cfa508b389049570b8da5b1..f7b5d5e27d3c3670dd2bf71063fe1e8e9a0b408d 100644
--- a/components/infobars/test/infobar_test.cc
+++ b/components/infobars/test/infobar_test.cc
@@ -26,6 +26,6 @@ const int infobars::InfoBar::kDefaultBarTargetHeight = 36;
 
 scoped_ptr<infobars::InfoBar> ConfirmInfoBarDelegate::CreateInfoBar(
     scoped_ptr<ConfirmInfoBarDelegate> delegate) {
-  NOTREACHED();
-  return scoped_ptr<infobars::InfoBar>();
+  return scoped_ptr<infobars::InfoBar>(new infobars::InfoBar(
+      delegate.PassAs<infobars::InfoBarDelegate>()));

[Peter Kasting, 2014/08/26 17:57:24]

If you need a real implementation here now, does that mean this is no longer a
"dummy" per the top-of-file comment?

Is this just a temporary situation until crbug.com/386171 is fixed?

[blundell, 2014/09/12 12:48:08]

Updated the comment. This is not just temporary in the sense that even after the
flow is changed to go through a client interface, the GoogleURLTracker unittests
will still require a test implementation of that interface wherein
CreateInfoBar() returns a non-NULL infobar.

 }