Componentize GoogleURLTracker unittest

Componentize GoogleURLTracker unittest

Minor changes needed to avoid requiring TestingProfile.

BUG=373244
Committed: https://crrev.com/51d51dbc4a3b5329a716a5dbddd76219514e3274
Cr-Commit-Position: refs/heads/master@{#294787}

[blundell, 2014-08-26 17:23:38]

blundell@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2014-08-26 17:57:24]

LGTM

https://codereview.chromium.org/501393004/diff/1/components/google/core/brows...
File components/google/core/browser/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/501393004/diff/1/components/google/core/brows...
components/google/core/browser/google_url_tracker_unittest.cc:265:
prefs_.registry()->RegisterStringPref(
Curiosity: Do these changes imply that TestingProfile is also registering these
prefs, but no longer needs to be doing so after this CL?

https://codereview.chromium.org/501393004/diff/1/components/infobars/test/inf...
File components/infobars/test/infobar_test.cc (right):

https://codereview.chromium.org/501393004/diff/1/components/infobars/test/inf...
components/infobars/test/infobar_test.cc:30:
delegate.PassAs<infobars::InfoBarDelegate>()));
If you need a real implementation here now, does that mean this is no longer a
"dummy" per the top-of-file comment?

Is this just a temporary situation until crbug.com/386171 is fixed?

[blundell, 2014-09-12 12:48:08]

https://codereview.chromium.org/501393004/diff/1/components/google/core/brows...
File components/google/core/browser/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/501393004/diff/1/components/google/core/brows...
components/google/core/browser/google_url_tracker_unittest.cc:265:
prefs_.registry()->RegisterStringPref(
On 2014/08/26 17:57:24, Peter Kasting wrote:
> Curiosity: Do these changes imply that TestingProfile is also registering
these
> prefs, but no longer needs to be doing so after this CL?

No, the registration was previously happening via the deleted call at line 265,
which calls GoogleURLTrackerFactory::RegisterProfilePrefs.

https://codereview.chromium.org/501393004/diff/1/components/infobars/test/inf...
File components/infobars/test/infobar_test.cc (right):

https://codereview.chromium.org/501393004/diff/1/components/infobars/test/inf...
components/infobars/test/infobar_test.cc:30:
delegate.PassAs<infobars::InfoBarDelegate>()));
On 2014/08/26 17:57:24, Peter Kasting wrote:
> If you need a real implementation here now, does that mean this is no longer a
> "dummy" per the top-of-file comment?
> 
> Is this just a temporary situation until crbug.com/386171 is fixed?

Updated the comment. This is not just temporary in the sense that even after the
flow is changed to go through a client interface, the GoogleURLTracker unittests
will still require a test implementation of that interface wherein
CreateInfoBar() returns a non-NULL infobar.

[blundell, 2014-09-12 12:48:11]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-09-12 12:48:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/501393004/20001

[commit-bot: I haz the power, 2014-09-12 12:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 12:51:33]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/55208)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[blundell, 2014-09-15 05:47:22]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-09-15 05:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/501393004/40001

[commit-bot: I haz the power, 2014-09-15 06:47:17]

Committed patchset #3 (id:40001) as 7279c71f88464c2ad857e56542a758e1672d6dc6

[commit-bot: I haz the power, 2014-09-15 06:52:11]

Patchset 3 (id:??) landed as
https://crrev.com/51d51dbc4a3b5329a716a5dbddd76219514e3274
Cr-Commit-Position: refs/heads/master@{#294787}