|
|
DescriptionAdding Select Action Bar Unit test case for input.
Currently not enought unit test case is available for Select Action Bar.
This change adding useful UT for Select Action Bar with respect to input
field.
BUG=
Committed: https://crrev.com/763e52f2af4117f5cc05fc90f2c1e3c80717a688
Cr-Commit-Position: refs/heads/master@{#291975}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Added utility function to reuse in future test cases. #Messages
Total messages: 15 (0 generated)
ajith.v@samsung.com changed reviewers: + aurimas@chromium.org, jdduke@chromium.org
PTAL
https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); Why not put this test in ContentViewCoreFocusTest?
https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); On 2014/08/26 15:01:46, jdduke wrote: > Why not put this test in ContentViewCoreFocusTest? ContentViewCoreFocusTest does not holding environment to load an HTML page and other utility functions used here. If I can replicate in ContentViewCoreFocusTest, then I am Ok to do that. Please share your opinion.
https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); On 2014/08/26 15:16:40, AKV wrote: > On 2014/08/26 15:01:46, jdduke wrote: > > Why not put this test in ContentViewCoreFocusTest? > > ContentViewCoreFocusTest does not holding environment to load an HTML page and > other utility functions used here. If I can replicate in > ContentViewCoreFocusTest, then I am Ok to do that. Please share your opinion. I don't have a strong opinion, so I'll defer to aurimas@ as to where these tests should go. Other than that, the test looks good, but why do you focus "input_radio" first?
https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javat... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); On 2014/08/26 15:20:39, jdduke wrote: > On 2014/08/26 15:16:40, AKV wrote: > > On 2014/08/26 15:01:46, jdduke wrote: > > > Why not put this test in ContentViewCoreFocusTest? > > > > ContentViewCoreFocusTest does not holding environment to load an HTML page and > > other utility functions used here. If I can replicate in > > ContentViewCoreFocusTest, then I am Ok to do that. Please share your opinion. > > I don't have a strong opinion, so I'll defer to aurimas@ as to where these tests > should go. Other than that, the test looks good, but why do you focus > "input_radio" first? Thanks for the comments. Without this line DOMUtils.focusNode(mContentViewCore, "input_radio"); When we long press on text field it expects Keyboard shown, which is contradicting as per actual behavior.This appears a test environment bug. All other places we are following same standard. For this environment bug, I will address separately outside of this patch.
@aurimas PTAL
@jdduke and aurimas added a utility function to reuse it for future UTs. PTAL
lgtm
@jdduke PTAL. Owner LGTM is missing to land this change.
On 2014/08/26 18:37:08, AKV wrote: > @jdduke PTAL. Owner LGTM is missing to land this change. lgtm
The CQ bit was checked by ajith.v@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajith.v@samsung.com/501383002/20001
Message was sent while issue was closed.
Committed patchset #2 (20001) as 981e4179c11f818263db1845f1027ffc43dc3ee3
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/763e52f2af4117f5cc05fc90f2c1e3c80717a688 Cr-Commit-Position: refs/heads/master@{#291975} |