Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 501383002: Adding Select Action Bar Unit test case for input. (Closed)

Created:
6 years, 3 months ago by AKVT
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding Select Action Bar Unit test case for input. Currently not enought unit test case is available for Select Action Bar. This change adding useful UT for Select Action Bar with respect to input field. BUG= Committed: https://crrev.com/763e52f2af4117f5cc05fc90f2c1e3c80717a688 Cr-Commit-Position: refs/heads/master@{#291975}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Added utility function to reuse in future test cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
AKVT
ajith.v@samsung.com changed reviewers: + aurimas@chromium.org, jdduke@chromium.org
6 years, 3 months ago (2014-08-26 14:06:39 UTC) #1
AKVT
PTAL
6 years, 3 months ago (2014-08-26 14:06:39 UTC) #2
jdduke (slow)
https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode178 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); Why not put this test in ContentViewCoreFocusTest?
6 years, 3 months ago (2014-08-26 15:01:47 UTC) #3
AKVT
https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode178 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); On 2014/08/26 15:01:46, jdduke wrote: > Why ...
6 years, 3 months ago (2014-08-26 15:16:40 UTC) #4
jdduke (slow)
https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode178 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); On 2014/08/26 15:16:40, AKV wrote: > On ...
6 years, 3 months ago (2014-08-26 15:20:40 UTC) #5
AKVT
https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/501383002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode178 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:178: DOMUtils.focusNode(mContentViewCore, "input_radio"); On 2014/08/26 15:20:39, jdduke wrote: > On ...
6 years, 3 months ago (2014-08-26 16:38:12 UTC) #6
AKVT
@aurimas PTAL
6 years, 3 months ago (2014-08-26 17:14:40 UTC) #7
AKVT
@jdduke and aurimas added a utility function to reuse it for future UTs. PTAL
6 years, 3 months ago (2014-08-26 17:42:46 UTC) #8
aurimas (slooooooooow)
lgtm
6 years, 3 months ago (2014-08-26 18:20:20 UTC) #9
AKVT
@jdduke PTAL. Owner LGTM is missing to land this change.
6 years, 3 months ago (2014-08-26 18:37:08 UTC) #10
jdduke (slow)
On 2014/08/26 18:37:08, AKV wrote: > @jdduke PTAL. Owner LGTM is missing to land this ...
6 years, 3 months ago (2014-08-26 18:46:48 UTC) #11
AKVT
The CQ bit was checked by ajith.v@samsung.com
6 years, 3 months ago (2014-08-26 19:12:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajith.v@samsung.com/501383002/20001
6 years, 3 months ago (2014-08-26 19:13:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (20001) as 981e4179c11f818263db1845f1027ffc43dc3ee3
6 years, 3 months ago (2014-08-26 20:11:57 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:24 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/763e52f2af4117f5cc05fc90f2c1e3c80717a688
Cr-Commit-Position: refs/heads/master@{#291975}

Powered by Google App Engine
This is Rietveld 408576698