Transfer canvas state to the next frame with noticable restrictions.

Source/platform/graphics/RecordingImageBufferSurface.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef RecordingImageBufferSurface_h
 #define RecordingImageBufferSurface_h
 
 #include "platform/graphics/ImageBufferSurface.h"
 #include "public/platform/WebThread.h"
+#include "third_party/skia/include/core/SkCanvas.h"
+#include "wtf/Deque.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/RefPtr.h"
 
 class SkPicture;
 class SkPictureRecorder;
 class RecordingImageBufferSurfaceTest;
 
 namespace blink {
 
 class ImageBuffer;
 
+// The same with the default state stack size in SkCanvas
+#define INITIAL_STATE_STACK_SIZE 1

[zino, 2014/09/03 10:50:17]

Should we use WTF::Deque? I think it is better to use WTF::LinkedStack.
Also, I'm not sure if WTF::Deque<..., 1> is able to expand the internal vector.

[Sergey, 2014/09/04 10:26:50]

Junov, what do you think? I would probably agree with Jinho, since LinkedStack
does not move objects, when it has to allocate more memory. And it seems Deque
is mostly design for big capacities, while I don't expect that anyone would
write a web page with more then 5-10 canvas state saves...

+
 class PLATFORM_EXPORT RecordingImageBufferSurface : public ImageBufferSurface {
     WTF_MAKE_NONCOPYABLE(RecordingImageBufferSurface); WTF_MAKE_FAST_ALLOCATED;
 public:
     RecordingImageBufferSurface(const IntSize&, OpacityMode = NonOpaque);
     virtual ~RecordingImageBufferSurface();
 
     // Implementation of ImageBufferSurface interfaces
     virtual SkCanvas* canvas() const OVERRIDE;
     virtual PassRefPtr<SkPicture> getPicture() OVERRIDE;
     virtual bool isValid() const OVERRIDE { return true; }
     virtual void willAccessPixels() OVERRIDE;
     virtual void finalizeFrame() OVERRIDE;
     virtual void didClearCanvas() OVERRIDE;
     virtual void setImageBuffer(ImageBuffer*) OVERRIDE;
 
 private:
+    struct StateRec {
+    public:

[zino, 2014/09/03 10:50:17]

Is this Blink coding rule?
If not so, I think this is unnecessary.

[Sergey, 2014/09/11 12:58:53]

Probably not required here at all.

+        SkMatrix m_ctm;
+        SkRect m_clip;

[zino, 2014/09/03 10:50:18]

If you use getDeviceClipBounds(), you should probably use SkIRect.

[Sergey, 2014/09/11 12:58:52]

Probably not required here at all.

+    };
+    typedef Deque<StateRec, INITIAL_STATE_STACK_SIZE> StateStack;
     friend class ::RecordingImageBufferSurfaceTest; // for unit testing
     void fallBackToRasterCanvas();
     void initializeCurrentFrame();
     bool finalizeFrameInternal();
 
+    // saves current clip and transform matrix of canvas
+    bool saveState(SkCanvas*, StateStack*);
+    // we should make sure that we can transfer state in saveState
+    void setCurrentState(SkCanvas*, StateStack*);
+
     OwnPtr<SkPictureRecorder> m_currentFrame;
     RefPtr<SkPicture> m_previousFrame;
     OwnPtr<SkCanvas> m_rasterCanvas;
     ImageBuffer* m_imageBuffer;
     int m_initialSaveCount;
     bool m_frameWasCleared;
 };
 
 } // namespace blink
 
 #endif