chrome/chrome_tests_unit.gypi - Issue 501303002: [Mac] Make app shims load the same framework version as the running Chrome process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 501303002: [Mac] Make app shims load the same framework version as the running Chrome process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index 77df767caeff158762387d26843dbb823b08bce7..274ed7773f002d1d01c51bb42720451775312837 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -1872,6 +1872,7 @@

'common/importer/firefox_importer_utils_unittest.cc',

'common/ini_parser_unittest.cc',

'common/instant_restricted_id_cache_unittest.cc',

+ 'common/mac/app_mode_chrome_locator_unittest.mm',

'common/mac/cfbundle_blocker_unittest.mm',

'common/mac/mock_launchd.cc',

'common/mac/mock_launchd.h',

@@ -2408,6 +2409,7 @@

'dependencies': [

'../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:google_toolbox_for_mac',

'../third_party/ocmock/ocmock.gyp:ocmock',

+ 'app_mode_app_support',

tapted 2014/08/26 08:43:47 you .. might need ios as well in the condition :/

jackhou1 2014/08/27 03:04:52 You mean OS=="mac" includes OS=="ios"? So I need O

tapted 2014/08/27 03:51:16 Ah, maybe not :). Depends what the bots say. OS_MA

'chrome',

'sources!': [

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/mac/app_mode_chrome_locator.h » ('j') | chrome/common/mac/app_mode_chrome_locator.mm » ('J')