Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: chrome/common/mac/app_mode_common.mm

Issue 501303002: [Mac] Make app shims load the same framework version as the running Chrome process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a comment. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/mac/app_mode_common.h" 5 #include "chrome/common/mac/app_mode_common.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 8
9 namespace app_mode { 9 namespace app_mode {
10 10
11 const char kAppShimSocketShortName[] = "Socket"; 11 const char kAppShimSocketShortName[] = "Socket";
12 const char kAppShimSocketSymlinkName[] = "App Shim Socket"; 12 const char kAppShimSocketSymlinkName[] = "App Shim Socket";
13 13
14 extern const char kAppShimVersionSymlinkName[] = "AppShimVersion";
tapted 2014/08/26 07:12:48 no `extern` here. Also maybe 'RunningChromeVersio
jackhou1 2014/08/26 08:15:14 Done.
15
14 const char kAppListModeId[] = "app_list"; 16 const char kAppListModeId[] = "app_list";
15 17
16 const char kLaunchedByChromeProcessId[] = "launched-by-chrome-process-id"; 18 const char kLaunchedByChromeProcessId[] = "launched-by-chrome-process-id";
17 const char kLaunchedForTest[] = "launched-for-test"; 19 const char kLaunchedForTest[] = "launched-for-test";
18 const char kLaunchedAfterRebuild[] = "launched-after-rebuild"; 20 const char kLaunchedAfterRebuild[] = "launched-after-rebuild";
19 21
20 const char kAppShimError[] = "app-shim-error"; 22 const char kAppShimError[] = "app-shim-error";
21 23
22 NSString* const kCFBundleDocumentTypesKey = @"CFBundleDocumentTypes"; 24 NSString* const kCFBundleDocumentTypesKey = @"CFBundleDocumentTypes";
23 NSString* const kCFBundleTypeExtensionsKey = @"CFBundleTypeExtensions"; 25 NSString* const kCFBundleTypeExtensionsKey = @"CFBundleTypeExtensions";
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 60
59 void VerifySocketPermissions(const base::FilePath& socket_path) { 61 void VerifySocketPermissions(const base::FilePath& socket_path) {
60 CHECK(base::PathIsWritable(socket_path)); 62 CHECK(base::PathIsWritable(socket_path));
61 base::FilePath socket_dir = socket_path.DirName(); 63 base::FilePath socket_dir = socket_path.DirName();
62 int socket_dir_mode = 0; 64 int socket_dir_mode = 0;
63 CHECK(base::GetPosixFilePermissions(socket_dir, &socket_dir_mode)); 65 CHECK(base::GetPosixFilePermissions(socket_dir, &socket_dir_mode));
64 CHECK_EQ(0700, socket_dir_mode); 66 CHECK_EQ(0700, socket_dir_mode);
65 } 67 }
66 68
67 } // namespace app_mode 69 } // namespace app_mode
OLDNEW
« chrome/common/mac/app_mode_chrome_locator_unittest.mm ('K') | « chrome/common/mac/app_mode_common.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698